Closed
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/test 4.12-upstream-e2e-mesh-aws-ocp-412 |
2 similar comments
Contributor
Author
|
/test 4.12-upstream-e2e-mesh-aws-ocp-412 |
Contributor
Author
|
/test 4.12-upstream-e2e-mesh-aws-ocp-412 |
Contributor
Author
|
/retest /test 4.12-upstream-e2e-mesh-aws-ocp-412 |
Contributor
Author
|
/test 4.12-upstream-e2e-mesh-aws-ocp-412 |
1 similar comment
Contributor
Author
|
/test 4.12-upstream-e2e-mesh-aws-ocp-412 |
mgencur
reviewed
Jul 7, 2023
| kind: PeerAuthentication | ||
| metadata: | ||
| name: default | ||
| namespace: eventing-e2e0 |
Contributor
There was a problem hiding this comment.
Just a note. eventing-e2e0 - eventing-e2e4 are namespaces used by upgrade tests. These tests do not run by default in CI with Service Mesh. We might need to define some rules for these namespaces as well.
Contributor
Author
There was a problem hiding this comment.
The working theory is, that adding it to istio-system will apply it to the whole mesh automatically. At least upstream istio does that and documents it. I'll ask the SM team if we can also use that.
Contributor
Author
|
Still 503s, but not really consistent Oo: /test 4.12-upstream-e2e-mesh-aws-ocp-412 |
Contributor
Author
|
/test 4.12-upstream-e2e-mesh-aws-ocp-412 |
Contributor
Author
|
Local run Need to dig a bit more to check |
ReToCode
force-pushed
the
multitenant_tests_reto
branch
from
61ff571 to
34c1cff
Compare
Contributor
Author
|
/test 4.12-upstream-e2e-mesh-aws-ocp-412 |
Contributor
|
@ReToCode: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
Author
|
/test 4.13-upstream-e2e-mesh-aws-ocp-413 |
mgencur
reviewed
Jul 14, 2023
Contributor
Author
|
This is now using an updated version of |
Contributor
Author
|
/test 4.13-upstream-e2e-mesh-aws-ocp-413 |
1 similar comment
Contributor
Author
|
/test 4.13-upstream-e2e-mesh-aws-ocp-413 |
The webhook needs to be installed for both upstream Serving tests and downstream serverless-operator tests. Better to install it at the beginning.
For DomainMapping test
ReToCode
force-pushed
the
multitenant_tests_reto
branch
from
bcea076 to
5a2a481
Compare
Contributor
Author
|
/test 4.13-upstream-e2e-mesh-aws-ocp-413 |
1 similar comment
Contributor
Author
|
/test 4.13-upstream-e2e-mesh-aws-ocp-413 |
Contributor
Author
|
Hm first try was better, the second has new flakes, that are not there locally: Moore digging... |
Contributor
Author
|
/test 4.13-upstream-e2e-mesh-aws-ocp-413 |
Contributor
Author
|
/test 4.13-upstream-e2e-mesh-aws-ocp-413 |
Contributor
Author
|
/test 4.13-upstream-e2e-mesh-aws-ocp-413 |
Contributor
Author
|
/test 4.13-upstream-e2e-mesh-aws-ocp-413 |
Contributor
Author
|
/test 4.13-upstream-e2e-mesh-aws-ocp-413 |
Contributor
Author
|
/retest |
…nstead of env variable
Contributor
Author
|
/test 4.13-upstream-e2e-mesh-aws-ocp-413 |
Contributor
|
@ReToCode: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
Author
|
/test 4.13-upstream-e2e-mesh-aws-ocp-413 |
Contributor
Author
|
Closing this approach in favour of the one with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional stuff to #2126 for testing.
/hold