Verify the deletion of the object when it is allowed#1123
Merged
openshift-merge-robot merged 1 commit intoopenshift-knative:mainfrom Jul 28, 2021
nak3:allow-delete
Merged
Verify the deletion of the object when it is allowed#1123openshift-merge-robot merged 1 commit intoopenshift-knative:mainfrom nak3:allow-delete
openshift-merge-robot merged 1 commit intoopenshift-knative:mainfrom
nak3:allow-delete
Conversation
Currently we confirm the deletion "when the client gets error". But we would get no error but object is still "terminating" status. So this patch changes the condition to "when Delete is allowed".
Contributor
Author
|
Here is the error the issue happen and I am thinking this PR can fix it. |
Contributor
|
LOL yeah, I totally inversed the condirtion 😂. Should've been |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes, nak3 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we confirm the deletion "when the client gets error".
But we would get no error but object still takes some time to be deleted completely.
So this patch changes the condition to "when Delete is allowed".
/cc @markusthoemmes @skonto @matzew