[SRVKS-743] Disable monitoring if istio is enabled#1036
Merged
openshift-merge-robot merged 2 commits intoopenshift-knative:mainfrom Jun 21, 2021
skonto:disable_monitoring
Merged
[SRVKS-743] Disable monitoring if istio is enabled#1036openshift-merge-robot merged 2 commits intoopenshift-knative:mainfrom skonto:disable_monitoring
openshift-merge-robot merged 2 commits intoopenshift-knative:mainfrom
skonto:disable_monitoring
Conversation
|
|
||
| // Temporary fix for SRVKS-743 | ||
| if ks.Spec.Ingress.Istio.Enabled { | ||
| common.Configure(&ks.Spec.CommonSpec, monitoring.ObservabilityCMName, monitoring.ObservabilityBackendKey, "none") |
Contributor
There was a problem hiding this comment.
let's make this ConfigureIfUnset just to leave the gate open for people who really want to play with it enabled explicitly.
Collaborator
Author
There was a problem hiding this comment.
Ok good to know updating in a sec.
Collaborator
Author
|
/assign @markusthoemmes |
Contributor
|
/retest Eventing error. I pinged eventing team on slack. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intended for 1.16 and should be fixed in 1.17.