[SRVKS-752] Add NetworkPolicy for webhook on net-istio ingress#1027
[SRVKS-752] Add NetworkPolicy for webhook on net-istio ingress#1027openshift-merge-robot merged 2 commits intoopenshift-knative:mainfrom nak3:jira-752
Conversation
|
Should we extract just the networkpolicy part of this? Seems simple enough on it's own to have at least that bug fixed? |
|
Sounds good! Updated. |
| - knative-serving | ||
| - serving-tests | ||
| - serving-tests-alt | ||
| - default |
There was a problem hiding this comment.
nit: Will this not break for cases where we don't use net-istio? Or will that never be the case?
There was a problem hiding this comment.
No, it will not break for cases where we don't use net-istio.
I added default namespace here, just because it is convenient for a local test.
|
/test 4.7-upstream-e2e-aws-ocp-47 infra. |
markusthoemmes
left a comment
markusthoemmes
left a comment
There was a problem hiding this comment.
/assign @maschmid
|
@nak3: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes, maschmid, nak3 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
This patch adds NetworkPolicy for webhook on net-istio.