Skip to content

Update reconciler-test to latest commit in release-1.11#313

Merged
openshift-merge-robot merged 2 commits intoopenshift-knative:release-v1.11from
creydr:update-reconciler-test-1.11
Aug 17, 2023
Merged

Update reconciler-test to latest commit in release-1.11#313
openshift-merge-robot merged 2 commits intoopenshift-knative:release-v1.11from
creydr:update-reconciler-test-1.11

Conversation

@creydr
Copy link
Copy Markdown
Collaborator

@creydr creydr commented Aug 11, 2023

@creydr
Copy link
Copy Markdown
Collaborator Author

creydr commented Aug 14, 2023

Follow up on #309 (comment)

/assign @matzew

@creydr
Copy link
Copy Markdown
Collaborator Author

creydr commented Aug 17, 2023

/cc @ReToCode

@openshift-ci openshift-ci bot requested a review from ReToCode August 17, 2023 09:18
@ReToCode
Copy link
Copy Markdown

You might want to include the latest one as well?

@creydr
Copy link
Copy Markdown
Collaborator Author

creydr commented Aug 17, 2023

You might want to include the latest one as well?

Included the commits from knative-extensions/reconciler-test@9e58415 too

Copy link
Copy Markdown

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7adda47 into openshift-knative:release-v1.11 Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants