Skip to content

[release-1.10] Bump reconciler-test to latest commit of release-1.10#766

Merged
openshift-merge-robot merged 2 commits into
openshift-knative:release-v1.10from
ReToCode:reconciler-test-fix
Aug 3, 2023
Merged

[release-1.10] Bump reconciler-test to latest commit of release-1.10#766
openshift-merge-robot merged 2 commits into
openshift-knative:release-v1.10from
ReToCode:reconciler-test-fix

Conversation

@ReToCode
Copy link
Copy Markdown

@ReToCode ReToCode commented Aug 3, 2023

@openshift-ci openshift-ci Bot requested review from aliok and pierDipi August 3, 2023 10:54
@ReToCode
Copy link
Copy Markdown
Author

ReToCode commented Aug 3, 2023

@pierDipi what about the other changes like vendor/knative.dev/reconciler-test/pkg/images/ko/publish.go. Are they ok or should I drop them?

@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Aug 3, 2023

did you run make generate-release?

Copy link
Copy Markdown
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm label Aug 3, 2023
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Aug 3, 2023
@ReToCode ReToCode changed the title [RELEASE 1.10] Bump reconciler-test to latest commit of release-1.10 [release-1.10] Bump reconciler-test to latest commit of release-1.10 Aug 3, 2023
@ReToCode
Copy link
Copy Markdown
Author

ReToCode commented Aug 3, 2023

/retest

@openshift-merge-robot openshift-merge-robot merged commit bf8f4e6 into openshift-knative:release-v1.10 Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants