Remove openshift-tools-installer workaround #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose R. Gonzalez <[email protected]>
komish
changed the title
This was referenced Jul 25, 2024
mgoerens
approved these changes
Jul 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the merging of redhat-actions/openshift-tools-installer#106, the openshift-tools-installer should now be using a Node20 runtime and the issue that was previously observed (3 minute delay for every execution) is now resolved.
This PR removes the workaround that was put in place that allowed a Node16 runtime to be used after its deprecation timeline.
As a sidenote, the [email protected] is already in use in the pipeline because the PR linked previously is included in the v1 resolution - so we're already using it we just don't need this environment variable anymore.
See here, the commit hash corresponds to https://github.com/redhat-actions/openshift-tools-installer/tree/v1.13