Skip to content

Conversation

@sosiouxme
Copy link
Contributor

@sosiouxme
Copy link
Contributor Author

/hold
need to gain confidence that openshift-eng/aos-cd-jobs#3990 will stick

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2023
@cgwalters
Copy link

need to gain confidence that openshift-eng/aos-cd-jobs#3990 will stick

Is it? I can bring some superglue if not

@sosiouxme
Copy link
Contributor Author

/hold cancel
fixed the only resulting problem, think we can move forward whenever you're ready to try this.
/approve

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sosiouxme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2023
@sosiouxme
Copy link
Contributor Author

/hold
sorry, good thing i checked...
driver-toolkit still has an image-reference to machine-os-content

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2023
@jlebon
Copy link

jlebon commented Nov 7, 2023

/hold sorry, good thing i checked... driver-toolkit still has an image-reference to machine-os-content

Yes, this is being removed in openshift/driver-toolkit#135.

At this point, it sounds like all the groundwork has been done and we just need to merge all three of this, openshift/driver-toolkit#135, and openshift/os#1374 at the same time?

@cgwalters
Copy link

Seems worth trying now yes!

@sosiouxme
Copy link
Contributor Author

/hold cancel
should eventually get a correct nightly after RHCOS and driver-toolkit rebuild.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2023
@jlebon
Copy link

jlebon commented Nov 8, 2023

We went ahead and merged openshift/os#1374. This should be good to go too now!

@sosiouxme sosiouxme merged commit 840fb81 into openshift-eng:openshift-4.15 Nov 9, 2023
@sosiouxme sosiouxme deleted the 20231102-remove-mosc branch November 9, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants