This repository was archived by the owner on Apr 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
[ART-3883] rhcos.schema.json: assembly may also specify rhel-coreos-8 #78
Merged
sosiouxme
merged 1 commit into
openshift-eng:master
from
sosiouxme:20220714-rhcos-container
Jul 19, 2022
Merged
[ART-3883] rhcos.schema.json: assembly may also specify rhel-coreos-8 #78
sosiouxme
merged 1 commit into
openshift-eng:master
from
sosiouxme:20220714-rhcos-container
Jul 19, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build #1 |
Build #2 |
sosiouxme
added a commit
to openshift-eng/doozer
that referenced
this pull request
Jul 19, 2022
https://issues.redhat.com/browse/ART-3883 We will need to configurably inject multiple containers from an RHCOS build into the payload. Eventually machine-os-content may not be the reference container and may not be present at all. https://github.com/openshift/ocp-build-data/pull/1773/files shows how we might expect config to look for the first additional container. openshift-eng/ocp-build-data-validator#78 enables `rhel-coreos-8` in assembly definitions.
ashwindasr
pushed a commit
to ashwindasr/art-tools
that referenced
this pull request
Jul 19, 2023
https://issues.redhat.com/browse/ART-3883 We will need to configurably inject multiple containers from an RHCOS build into the payload. Eventually machine-os-content may not be the reference container and may not be present at all. https://github.com/openshift/ocp-build-data/pull/1773/files shows how we might expect config to look for the first additional container. openshift-eng/ocp-build-data-validator#78 enables `rhel-coreos-8` in assembly definitions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basically whenever RHCOS adds another container, we can just allow it here like this.
eventually we'll probably need to make
machine-os-contentnot required and add other restrictions, but that's for later.