Skip to content

SPLAT-2538: Map cloud-provider-aws-e2e tests to Cloud Controller Manager component#525

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-eng:mainfrom
mtulio:map-cloud-provider-aws-e2e-tests
Dec 4, 2025
Merged

SPLAT-2538: Map cloud-provider-aws-e2e tests to Cloud Controller Manager component#525
openshift-merge-bot[bot] merged 1 commit intoopenshift-eng:mainfrom
mtulio:map-cloud-provider-aws-e2e-tests

Conversation

@mtulio
Copy link
Copy Markdown
Contributor

@mtulio mtulio commented Dec 4, 2025

Summary

This PR addresses OCPBUGS-65885 by mapping all cloud-provider-aws-e2e tests to the Cloud Compute / Cloud Controller Manager component.

Changes

  • Added a new matcher in pkg/components/cloudcompute/cloudcontrollermanager/component.go to match all tests containing "cloud-provider-aws-e2e"
  • Regenerated test mappings using make mapping

Tests Mapped

All 7 cloud-provider-aws-e2e tests are now correctly mapped from "Unknown" to "Cloud Compute / Cloud Controller Manager":

  1. [cloud-provider-aws-e2e] loadbalancer NLB should be reachable with target-node-labels
  2. [cloud-provider-aws-e2e] loadbalancer NLB internal should be reachable with hairpinning traffic
  3. [cloud-provider-aws-e2e] loadbalancer CLB internal should be reachable with hairpinning traffic
  4. [cloud-provider-aws-e2e] loadbalancer CLB should be reachable with default configurations
  5. [cloud-provider-aws-e2e] loadbalancer NLB should be reachable with default configurations
  6. [cloud-provider-aws-e2e] nodes should label nodes with topology network info if instance is supported
  7. [cloud-provider-aws-e2e] nodes should set zone-id topology label

Test plan

  • Ran make mapping successfully
  • Verified the two specific tests mentioned in OCPBUGS-65885 are now mapped to Cloud Controller Manager component
  • Verified all cloud-provider-aws-e2e tests are properly attributed

🤖 Generated with Claude Code

This change addresses OCPBUGS-65885 by mapping all cloud-provider-aws-e2e
tests to the Cloud Compute / Cloud Controller Manager component.

Previously, these tests were unmapped (showing as "Unknown" component).
This includes the two specific tests mentioned in the bug:
- [cloud-provider-aws-e2e] loadbalancer NLB should be reachable with target-node-labels
- [cloud-provider-aws-e2e] loadbalancer NLB internal should be reachable with hairpinning traffic

All 7 cloud-provider-aws-e2e tests are now correctly attributed to the
Cloud Controller Manager component.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@mtulio mtulio changed the title Map cloud-provider-aws-e2e tests to Cloud Controller Manager component OCPBUGS-65885: Map cloud-provider-aws-e2e tests to Cloud Controller Manager component Dec 4, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 4, 2025
@openshift-ci-robot
Copy link
Copy Markdown

@mtulio: This pull request references Jira Issue OCPBUGS-65885, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

This PR addresses OCPBUGS-65885 by mapping all cloud-provider-aws-e2e tests to the Cloud Compute / Cloud Controller Manager component.

Changes

  • Added a new matcher in pkg/components/cloudcompute/cloudcontrollermanager/component.go to match all tests containing "cloud-provider-aws-e2e"
  • Regenerated test mappings using make mapping

Tests Mapped

All 7 cloud-provider-aws-e2e tests are now correctly mapped from "Unknown" to "Cloud Compute / Cloud Controller Manager":

  1. [cloud-provider-aws-e2e] loadbalancer NLB should be reachable with target-node-labels
  2. [cloud-provider-aws-e2e] loadbalancer NLB internal should be reachable with hairpinning traffic
  3. [cloud-provider-aws-e2e] loadbalancer CLB internal should be reachable with hairpinning traffic
  4. [cloud-provider-aws-e2e] loadbalancer CLB should be reachable with default configurations
  5. [cloud-provider-aws-e2e] loadbalancer NLB should be reachable with default configurations
  6. [cloud-provider-aws-e2e] nodes should label nodes with topology network info if instance is supported
  7. [cloud-provider-aws-e2e] nodes should set zone-id topology label

Test plan

  • Ran make mapping successfully
  • Verified the two specific tests mentioned in OCPBUGS-65885 are now mapped to Cloud Controller Manager component
  • Verified all cloud-provider-aws-e2e tests are properly attributed

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from neisw and stbenjam December 4, 2025 05:27
@mtulio mtulio changed the title OCPBUGS-65885: Map cloud-provider-aws-e2e tests to Cloud Controller Manager component SPLAT-2538: Map cloud-provider-aws-e2e tests to Cloud Controller Manager component Dec 4, 2025
@openshift-ci-robot openshift-ci-robot removed the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 4, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 4, 2025

@mtulio: This pull request references SPLAT-2538 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Summary

This PR addresses OCPBUGS-65885 by mapping all cloud-provider-aws-e2e tests to the Cloud Compute / Cloud Controller Manager component.

Changes

  • Added a new matcher in pkg/components/cloudcompute/cloudcontrollermanager/component.go to match all tests containing "cloud-provider-aws-e2e"
  • Regenerated test mappings using make mapping

Tests Mapped

All 7 cloud-provider-aws-e2e tests are now correctly mapped from "Unknown" to "Cloud Compute / Cloud Controller Manager":

  1. [cloud-provider-aws-e2e] loadbalancer NLB should be reachable with target-node-labels
  2. [cloud-provider-aws-e2e] loadbalancer NLB internal should be reachable with hairpinning traffic
  3. [cloud-provider-aws-e2e] loadbalancer CLB internal should be reachable with hairpinning traffic
  4. [cloud-provider-aws-e2e] loadbalancer CLB should be reachable with default configurations
  5. [cloud-provider-aws-e2e] loadbalancer NLB should be reachable with default configurations
  6. [cloud-provider-aws-e2e] nodes should label nodes with topology network info if instance is supported
  7. [cloud-provider-aws-e2e] nodes should set zone-id topology label

Test plan

  • Ran make mapping successfully
  • Verified the two specific tests mentioned in OCPBUGS-65885 are now mapped to Cloud Controller Manager component
  • Verified all cloud-provider-aws-e2e tests are properly attributed

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio
Copy link
Copy Markdown
Contributor Author

mtulio commented Dec 4, 2025

/assign @dgoodwin

@dgoodwin
Copy link
Copy Markdown
Contributor

dgoodwin commented Dec 4, 2025

/lgtm

In future probably best to use the [Jira:"my component"] syntax to get this automatically. Looks like I failed to suggest that in the bug, apologies for that. but this is good enough.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Dec 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, mtulio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 41b6d21 into openshift-eng:main Dec 4, 2025
4 checks passed
@mtulio mtulio deleted the map-cloud-provider-aws-e2e-tests branch December 4, 2025 15:03
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

Fix included in accepted release 4.22.0-0.nightly-2026-01-22-122134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants