Skip to content

Comments

WRKLDS-1431: Update testname mapping for renamed tests due to removed apps.openshift.io dependency#148

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-eng:mainfrom
ingvagabund:update-testname-mapping
Oct 14, 2024
Merged

WRKLDS-1431: Update testname mapping for renamed tests due to removed apps.openshift.io dependency#148
openshift-merge-bot[bot] merged 1 commit intoopenshift-eng:mainfrom
ingvagabund:update-testname-mapping

Conversation

@ingvagabund
Copy link
Contributor

@ingvagabund ingvagabund commented Sep 9, 2024

@openshift-ci openshift-ci bot requested review from deepsm007 and dgoodwin September 9, 2024 10:49
@ingvagabund ingvagabund force-pushed the update-testname-mapping branch from 1547dc5 to 36c900c Compare September 9, 2024 10:49
@ingvagabund ingvagabund mentioned this pull request Sep 9, 2024
Merged
@ingvagabund ingvagabund changed the title Update testname mapping for renamed tests due to removed apps.openshift.io dependency WRKLDS-1431: Update testname mapping for renamed tests due to removed apps.openshift.io dependency Sep 9, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 9, 2024 •
edited by openshift-ci bot
Loading

@ingvagabund: This pull request references WRKLDS-1431 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead.

Details

In response to this:

For openshift/origin#28957.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ingvagabund ingvagabund force-pushed the update-testname-mapping branch 2 times, most recently from 012ce91 to 8e79cbe Compare September 9, 2024 11:00
@stbenjam
Copy link
Member

stbenjam commented Oct 1, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2024
@ingvagabund
Copy link
Contributor Author

ingvagabund commented Oct 1, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2024
@ingvagabund
Copy link
Contributor Author

ingvagabund commented Oct 1, 2024

Until openshift/origin#28957 merges

@ingvagabund ingvagabund force-pushed the update-testname-mapping branch from 8e79cbe to 6e88ed5 Compare October 14, 2024 09:21
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2024
@ingvagabund
Copy link
Contributor Author

ingvagabund commented Oct 14, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2024
@ingvagabund ingvagabund force-pushed the update-testname-mapping branch from 6e88ed5 to 64f7cad Compare October 14, 2024 10:21
@ingvagabund
Copy link
Contributor Author

ingvagabund commented Oct 14, 2024

@stbenjam would you please lgtm? The PR is ready.

@stbenjam
Copy link
Member

stbenjam commented Oct 14, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c1b9e0b into openshift-eng:main Oct 14, 2024
@ingvagabund ingvagabund deleted the update-testname-mapping branch October 14, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deepsm007 deepsm007 Awaiting requested review from deepsm007

@dgoodwin dgoodwin Awaiting requested review from dgoodwin

Assignees

@stbenjam stbenjam

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ingvagabund @openshift-ci-robot @stbenjam