Skip to content

Conversation

@ashwindasr
Copy link
Contributor

@ashwindasr ashwindasr commented Jul 15, 2024

Follows #772, where we accidentally included a regression to the fallback logic. We need to fallback when the file does not exist, not the field itself.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ashwindasr. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2024

@ashwindasr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 6ef8de7 link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ashwindasr
Copy link
Contributor Author

rebase succeeded

@ashwindasr ashwindasr merged commit 365334d into openshift-eng:main Jul 15, 2024
@ashwindasr ashwindasr deleted the fix-fallback branch July 15, 2024 17:24
@ashwindasr ashwindasr mentioned this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant