Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prerequisites.yml play to install-origin-release.sh #999

Conversation

michaelgugino
Copy link
Contributor

This commit adds prerequisites.yml to
test script to ensure properly cluster deployment.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 17, 2018
@stevekuznetsov
Copy link
Contributor

Lucky #999 !

-e oreg_url='openshift/origin-${component}:'"$( cat ./ORIGIN_COMMIT )" \
-e openshift_disable_check=docker_image_availability,package_update,package_availability \
${playbook_base}prerequisites.yml

if [[ -s "${playbook_base}/openshift-node/network_manager.yml" ]]; then
playbook="${playbook_base}openshift-node/network_manager.yml"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a / here after "${playbook_base}"? Looks like it may be an unrelated bug? Or actually remove the / from the if [[ -s check?

This commit adds prerequisites.yml to
test script to ensure properly cluster deployment.
@michaelgugino michaelgugino force-pushed the fix-install-origin-release branch from 91ac9c0 to 3142d0d Compare January 17, 2018 20:21
@jim-minter
Copy link
Contributor

looks like the PR has been updated to resolve your comment @stevekuznetsov - then can we get the new docker RPM into the AMI? :)

@stevekuznetsov stevekuznetsov merged commit 0daa218 into openshift-eng:master Jan 18, 2018
@stevekuznetsov
Copy link
Contributor

Yep, once this is picked up into the job hopefully we will see it bring the new RPM in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants