images: disable repo metadata signature check for gh-cli RPM repo - #748
Conversation
The GitHub CLI RPM repository (cli.github.com/packages/rpm) intermittently fails to serve valid GPG signatures on its repository metadata (repomd.xml.asc), causing recurring CI image build failures during `dnf install gh`. Remove repo_gpgcheck=1 to stop verifying repository metadata signatures while retaining gpgcheck=1 and the checked-in GPG key so that individual RPM packages are still signature-verified. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe GitHub CLI RPM repository definition removes the ChangesGitHub CLI repository
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change avoids image-build failures caused by intermittent repository metadata signature verification while retaining RPM package signature verification. No current merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/close |
|
@bryan-cox: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/reopen The metadata isn't signed but the actual package is |
|
/reopen |
|
@not-stbenjam: You can't reopen an issue/PR unless you authored it or you are a collaborator. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@bryan-cox: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/reopen |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: not-stbenjam, redhat-chai-bot, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
The
gh-cliRPM repository intermittently fails repository-metadata signature verification forrepomd.xml.asc, causing the images job to disable the repository and fail to installgh.Remove
repo_gpgcheck=1fromimages/repos/gh-cli.repoto avoid the failing metadata check. Package-level RPM verification remains enabled withgpgcheck=1and the checked-inRPM-GPG-KEY-gh-clikey.Validation
4aad16acc23f58c92f48c8c461164721dd825657AI-generated. Review for accuracy.
@bryan-cox requested via Chai Bot
Summary by CodeRabbit