Skip to content

images: disable repo metadata signature check for gh-cli RPM repo - #748

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-eng:mainfrom
redhat-chai-bot:fix-gh-cli-repo-metadata-signature
Sep 9, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift-eng:mainfrom
redhat-chai-bot:fix-gh-cli-repo-metadata-signature

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Summary

The gh-cli RPM repository intermittently fails repository-metadata signature verification for repomd.xml.asc, causing the images job to disable the repository and fail to install gh.

Remove repo_gpgcheck=1 from images/repos/gh-cli.repo to avoid the failing metadata check. Package-level RPM verification remains enabled with gpgcheck=1 and the checked-in RPM-GPG-KEY-gh-cli key.

Validation

  • Pre-commit review completed with no blocking findings
  • Complete diff review
  • Working tree clean
  • Remote branch SHA verified at 4aad16acc23f58c92f48c8c461164721dd825657
  • The remaining validation for the images path is the Prow image build

AI-generated. Review for accuracy.

@bryan-cox requested via Chai Bot

Summary by CodeRabbit

  • Chores
    • Updated the GitHub CLI RPM package configuration by removing an obsolete repository verification setting.

The GitHub CLI RPM repository (cli.github.com/packages/rpm) intermittently
fails to serve valid GPG signatures on its repository metadata
(repomd.xml.asc), causing recurring CI image build failures during
`dnf install gh`.

Remove repo_gpgcheck=1 to stop verifying repository metadata signatures
while retaining gpgcheck=1 and the checked-in GPG key so that individual
RPM packages are still signature-verified.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci
openshift-ci Bot requested review from cblecker and stleerh September 9, 2026 12:12
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 755db920-a7d0-428a-9c23-74b056e1e692

📥 Commits

Reviewing files that changed from the base of the PR and between 9087f8a and 4aad16a.

📒 Files selected for processing (1)
  • images/repos/gh-cli.repo
💤 Files with no reviewable changes (1)
  • images/repos/gh-cli.repo

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The GitHub CLI RPM repository definition removes the repo_gpgcheck=1 setting.

Changes

GitHub CLI repository

Layer / File(s) Summary
Update repository signature configuration
images/repos/gh-cli.repo
Removes the repo_gpgcheck=1 repository signature check setting.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 4aad1

This change avoids image-build failures caused by intermittent repository metadata signature verification while retaining RPM package signature verification. No current merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: disabling repository metadata signature checks for the gh-cli RPM repository while matching the configuration change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No Real People Names In Style References ✅ Passed PASS: The pull request changes only images/repos/gh-cli.repo, removing repo_gpgcheck=1. The diff contains no plugin command, skill documentation, example prompt, instruction, or style reference na…
No Assumed Git Remote Names ✅ Passed The pull request changes only images/repos/gh-cli.repo and removes repo_gpgcheck=1. The complete patch and commit metadata contain no origin or upstream remote-name usage. The repository-wide …
Git Push Safety Rules ✅ Passed PASS. The pull request changes only images/repos/gh-cli.repo and removes one repository setting. The committed patch contains no git push, force-push option, protected-branch push, or automated pu…
No Untrusted Mcp Servers ✅ Passed PASS: The pull request changes only images/repos/gh-cli.repo and deletes repo_gpgcheck=1. The diff adds no MCP server, package, installation command, or dependency. The remaining cli.github.com
Ai-Helpers Overlap Detection ✅ Passed PASS. The PR changes only images/repos/gh-cli.repo (one line removed). It does not add or modify plugins/*/commands/*.md, plugins/*/skills/*/SKILL.md, or agents/*.md. The AI-Helpers overlap ch…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@bryan-cox

Copy link
Copy Markdown
Contributor

/close

@openshift-ci openshift-ci Bot closed this Sep 9, 2026
@openshift-ci

openshift-ci Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@bryan-cox: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@not-stbenjam

Copy link
Copy Markdown
Contributor

/reopen
/lgtm
/approve

The metadata isn't signed but the actual package is

@bryan-cox

Copy link
Copy Markdown
Contributor

/reopen

@openshift-ci

openshift-ci Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@not-stbenjam: You can't reopen an issue/PR unless you authored it or you are a collaborator.

Details

In response to this:

/reopen
/lgtm
/approve

The metadata isn't signed but the actual package is

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot reopened this Sep 9, 2026
@openshift-ci

openshift-ci Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@bryan-cox: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stbenjam

stbenjam commented Sep 9, 2026

Copy link
Copy Markdown
Member

/reopen
/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2026
@openshift-ci

openshift-ci Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: not-stbenjam, redhat-chai-bot, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 3089f13 into openshift-eng:main Sep 9, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants