Skip to content

fix(jira-solve): remove inline verification block from solve command #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 4 commits into from
Jul 14, 2026
Merged

fix(jira-solve): remove inline verification block from solve command #620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
88d0e88
fix(jira-solve): remove inline verification block from solve command
enxebre Jul 14, 2026
2e14569
chore(jira): bump plugin version to 0.8.4
enxebre Jul 14, 2026
fcf0215
chore: regenerate docs
enxebre Jul 14, 2026
d621dc4
chore(openshift-developer): bump version to 1.1.10
enxebre Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1413,7 +1413,7 @@ <h1>ai-helpers</h1>
{
"name": "jira",
"description": "A plugin to automate tasks with Jira",
"version": "0.8.3",
"version": "0.8.4",
"has_readme": true,
"commands": [
{
Expand Down Expand Up @@ -2417,7 +2417,7 @@ <h1>ai-helpers</h1>
{
"name": "openshift-developer",
"description": "Bundle of curated plugins, skills, and MCP servers useful to any OpenShift engineer",
"version": "1.1.9",
"version": "1.1.10",
"has_readme": true,
"commands": [],
"skills": [
Expand Down
2 changes: 1 addition & 1 deletion plugins/jira/.claude-plugin/plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "jira",
"description": "A plugin to automate tasks with Jira",
"version": "0.8.3",
"version": "0.8.4",

@coderabbitai coderabbitai Bot Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Synchronize downstream Jira version metadata.

The manifest now declares 0.8.4, but .claude-plugin/marketplace.json and docs/index.html still advertise 0.8.3. Run the repository’s version-sync workflow and commit the generated updates so marketplace consumers and documentation resolve the same release version.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@plugins/jira/.claude-plugin/plugin.json` at line 4, Synchronize the version
metadata for the release declared in the plugin manifest at 0.8.4. Run the
repository’s established version-sync workflow, ensuring
.claude-plugin/marketplace.json and docs/index.html are regenerated to advertise
0.8.4 consistently.

@bryan-cox bryan-cox Jul 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a false positive — docs/index.html is already updated to 0.8.4 in this PR (see the diff for that file). There is no marketplace.json in the jira plugin directory either. The versions are synchronized.

@coderabbitai coderabbitai Bot Jul 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
fd -i marketplace.json
echo "---"
rg -n "0\.8\.[0-9]" docs/index.html
echo "---"
rg -n "\"version\"" plugins/jira/.claude-plugin/plugin.json

Length of output: 354

@bryan-cox You're right — I confirmed there's no marketplace.json file anywhere in the repository, and docs/index.html already shows "version": "0.8.4" at Line 1416, matching the manifest. The versions are indeed synchronized. Thanks for catching that false positive.

(=^･ω･^=) apologies for the noise!

"author": {
"name": "github.com/openshift-eng"
}
Expand Down
22 changes: 0 additions & 22 deletions plugins/jira/commands/solve.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,28 +71,6 @@ This command takes a JIRA URL, fetches the issue description and requirements, a
- Use your best judgement if godoc comments are needed for private functions
- For example, a comment should not be generated for a simple function like func add(int a, b) int { return a + b}
- Create unit tests for any newly created functions
- After making code changes, you MUST verify the implementation based on the repository's tooling:
- **Check for Makefile**: Run `ls Makefile` to see if one exists
- **If Makefile exists**: Check available targets with `make help` or `grep '^[^#]*:' Makefile | head -20`
- **Run appropriate verification commands**:
- If `make lint-fix` exists: Run it to ensure imports are sorted and linting issues are fixed
- If `make verify`, `make build`, `make test` exist: you MUST run these to ensure code builds and passes tests
- If no Makefile or make targets: Look for alternative commands:
- Go projects: `go fmt ./...`, `go vet ./...`, `go test ./...`, `go build ./...`
- Node.js: `npm test`, `npm run build`, `npm run lint`
- Python: `pytest`, `python -m unittest`, `pylint`, `black .`
- Other: Follow repository conventions in CI config files (.github/workflows/, .gitlab-ci.yml, etc.)
- **Never assume make targets exist** - always verify first
- **If any verification command fails**:
- Determine whether the failure is caused by your changes or is pre-existing
- If caused by your changes: fix the issue and re-run the failing command
- If pre-existing: note the pre-existing failure in the PR description, but still proceed
- **You MUST NOT proceed to "Commit Creation" until all verification commands have been run and all failures are either fixed or confirmed pre-existing**
- **Anti-patterns (explicitly forbidden)**:
- Do NOT run `go test ./changed/package/` instead of `make test` — running only the packages you changed misses cross-package regressions
- Do NOT skip `make test` because `make lint-fix` had unrelated failures
- Do NOT assume targeted package tests are "good enough" as a substitute for the full test suite

4. **Commit Creation**:
- Create feature branch using the jira-key $1 as the branch name. For example: "git checkout -b fix-{jira-key}"
- Break commits into logical components based on the nature of the changes
Expand Down
4 changes: 2 additions & 2 deletions plugins/openshift-developer/.claude-plugin/plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"name": "openshift-developer",
"description": "Bundle of curated plugins, skills, and MCP servers useful to any OpenShift engineer",
"version": "1.1.9",
"version": "1.1.10",
"author": {
"name": "github.com/openshift-eng"
},
"dependencies": [
{ "name": "jira", "version": "^0.8.2" },
{ "name": "jira", "version": "^0.8.4" },
{ "name": "ci", "version": "^0.0.52" },
{ "name": "golang", "version": "^0.3.0" },
{ "name": "prodsec-skills" },
Expand Down