ci: default OCP 5.x fresh installs to RHCOS 10 - #548
openshift-merge-bot[bot] merged 1 commit into
Conversation
OCP 5.x clusters installed fresh now use RHCOS 10 as default. Clusters installed as OCP 4.x (including major upgrades to 5.x) remain on RHCOS 9. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
openshift-ci
Bot
added
the
approved
WalkthroughThe CI plugin is updated to recognize OCP 5.x as defaulting to RHCOS 10 at install time instead of RHCOS 9. The ChangesRHCOS 10 default variant support and ci plugin version bump
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/test eval-payload-analysis |
029b152 to
4ad2801
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (3)
plugins/ci/skills/prow-job-analyze-test-failure/SKILL.md (1)
99-101: 💤 Low valueAdd language identifier to fenced code block.
The opening triple backticks on line 99 should specify a language (e.g.,
text) for compliance with Markdown linting standards.Fix: Add language identifier
- ``` + ```text artifacts/{target}/gather-extra/artifacts/nodes.json - ``` + ```🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@plugins/ci/skills/prow-job-analyze-test-failure/SKILL.md` around lines 99 - 101, The fenced code block containing the artifact path "artifacts/{target}/gather-extra/artifacts/nodes.json" is missing a language identifier after the opening triple backticks, which violates Markdown linting standards. Add the language identifier "text" to the opening backticks (change ``` to ```text) to specify the code block's content type and ensure compliance with linting rules.Source: Linters/SAST tools
plugins/ci/references/jobs.md (1)
54-54: ⚡ Quick winAdd language identifiers to code blocks for clarity.
The bash code blocks at lines 54 and 70 lack language specifications. Add
bashto the opening fence to improve readability and fix linter warnings.Proposed fix for code block language identifiers
This is a JSON file containing Node resources. Use `prow-job-artifact-search` to find and fetch it: -``` +```bash # Find nodes.json prow_job_artifact_search.py <url> search "**/nodes.json" artifactsand
-
+bashFetch it
prow_job_artifact_search.py fetch artifacts/{target}/gather-extra/artifacts/nodes.json
</details> Also applies to: 70-70 <details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.In
@plugins/ci/references/jobs.mdat line 54, The bash code blocks in the file
plugins/ci/references/jobs.md at lines 54 and 70 are missing language
identifiers which impacts readability and triggers linter warnings. Add the bash
language specifier to both code blocks by changing the opening fence from ``` toplugins/ci/skills/prow-job-analyze-install-failure/SKILL.md (1)
142-144: ⚡ Quick winAdd language identifier to the code block path example.
Line 142's fenced code block lacks a language identifier. Since it shows a filesystem path, add a language identifier (e.g.,
textor leave it empty, but most importantly fix the linter warning).Proposed fix
Use `prow-job-artifact-search` to look for `nodes.json` in gather-extra: -``` +```text artifacts/{target}/gather-extra/artifacts/nodes.json -``` +```🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@plugins/ci/skills/prow-job-analyze-install-failure/SKILL.md` around lines 142 - 144, Add a language identifier to the opening fence of the code block at line 142 in the SKILL.md file. The code block currently has a bare opening fence (```) but should include a language identifier such as `text` (e.g., ```text) to resolve the markdown linter warning. The closing fence should remain unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@plugins/ci/references/jobs.md`:
- Line 54: The bash code blocks in the file plugins/ci/references/jobs.md at
lines 54 and 70 are missing language identifiers which impacts readability and
triggers linter warnings. Add the bash language specifier to both code blocks by
changing the opening fence from ``` to ```bash for each of the two bash code
blocks at these locations.
In `@plugins/ci/skills/prow-job-analyze-install-failure/SKILL.md`:
- Around line 142-144: Add a language identifier to the opening fence of the
code block at line 142 in the SKILL.md file. The code block currently has a bare
opening fence (```) but should include a language identifier such as `text`
(e.g., ```text) to resolve the markdown linter warning. The closing fence should
remain unchanged.
In `@plugins/ci/skills/prow-job-analyze-test-failure/SKILL.md`:
- Around line 99-101: The fenced code block containing the artifact path
"artifacts/{target}/gather-extra/artifacts/nodes.json" is missing a language
identifier after the opening triple backticks, which violates Markdown linting
standards. Add the language identifier "text" to the opening backticks (change
``` to ```text) to specify the code block's content type and ensure compliance
with linting rules.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: fb6e130b-d484-44b6-b798-0e5992c89bfa
📒 Files selected for processing (6)
.claude-plugin/marketplace.jsondocs/index.htmlplugins/ci/.claude-plugin/plugin.jsonplugins/ci/references/jobs.mdplugins/ci/skills/prow-job-analyze-install-failure/SKILL.mdplugins/ci/skills/prow-job-analyze-test-failure/SKILL.md
✅ Files skipped from review due to trivial changes (1)
- docs/index.html
|
/test eval-payload-analysis |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
OCP 5.x clusters installed fresh now default to RHCOS 10 (
rhcos10-default) instead of RHCOS 9. Clusters installed as OCP 4.x (including major upgrades to 5.x) remain on RHCOS 9 (rhcos9-default).🤖 Generated with Claude Code
Summary by CodeRabbit
Chores
Documentation
Improvements