Skip to content

Update skillsaw to 0.14.0 and add quality badge - #542

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-eng:mainfrom
stbenjam:skillsaw-0.14.0
Jun 12, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift-eng:mainfrom
stbenjam:skillsaw-0.14.0

Conversation

@stbenjam

@stbenjam stbenjam commented Jun 12, 2026

Copy link
Copy Markdown
Member

Skillsaw is about 3x faster now, and this adds a badge to the README.md.

Summary

  • Update skillsaw from 0.13.1 to 0.14.0 (2.3-2.6x faster linting, badge support)
  • Add shields.io quality grade badge to README (A+)
  • Add .skillsaw-badge.json for dynamic badge updates

Test plan

  • skillsaw runs clean against the repo (A+ grade, 0 errors, 0 warnings)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation

    • Added a visible "skillsaw" quality badge to the README showing an A+ grade.
  • Chores

    • Upgraded Skillsaw tooling and CI integration to the 0.14.0 release across workflows and build scripts.
    • Updated local tooling references so project tasks (lint, test, docs) run against the newer Skillsaw image.

@openshift-ci
openshift-ci Bot requested review from brandisher and rvanderp3 June 12, 2026 21:15
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2026
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Bumps Skillsaw tool to v0.14.0 in config, Makefile, and CI workflows; adds/updates .skillsaw-badge.json with an A+ brightgreen badge and inserts the badge link into the README.

Changes

Skillsaw Badge Integration

Layer / File(s) Summary
Tooling and workflow version bumps
.skillsaw.yaml, Makefile, .github/workflows/lint-plugins.yml, .github/workflows/lint-review.yml, .github/workflows/update-docs.yml
Bump Skillsaw from 0.13.1 to 0.14.0: update .skillsaw.yaml version, SKILLSAW_IMAGE in Makefile, and pinned action SHAs / installed versions in CI workflows.
Badge configuration and README integration
.skillsaw-badge.json, README.md
Replace badge JSON with schemaVersion: 1 and metadata (label: skillsaw, message: A+, color: brightgreen, inline logoSvg), and add a skillsaw-grade badge link to the README.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

lgtm

Suggested reviewers

  • brandisher
  • rvanderp3
🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately captures the two main changes: updating skillsaw to version 0.14.0 and adding a quality badge to the repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No Real People Names In Style References ✅ Passed Searched PR #542 changed files for real-person style-reference patterns (e.g., “style of”, “like”, “voice of”); none found—only skillsaw version/badge/workflow updates.
No Assumed Git Remote Names ✅ Passed In git diff main..HEAD, the only README change is adding the skillsaw badge; the PR diff contains no origin/upstream mentions in added lines.
Git Push Safety Rules ✅ Passed Checked PR-touched files (.skillsaw-badge.json, .skillsaw.yaml, README.md, lint-plugins.yml, lint-review.yml, update-docs.yml, Makefile): none contain git push, --force, or --force-with-lease.
No Untrusted Mcp Servers ✅ Passed PR only bumps Skillsaw to 0.14.0 and updates badge/config/workflows; no MCP server install deps found (no mcp-server or npx @/mcp-server- usage in changed files).
Ai-Helpers Overlap Detection ✅ Passed PR changes vs origin/main are only .github/workflows, .skillsaw-, Makefile, and README; none match plugins//commands/.md, plugins//skills//SKILL.md, or agents/.md, so overlap detection is ski...
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Makefile`:
- Line 7: The SKILLSAW_IMAGE Makefile variable is set to an apparently
nonexistent tag (SKILLSAW_IMAGE = ghcr.io/stbenjam/skillsaw:0.14.0); verify the
correct image tag and update SKILLSAW_IMAGE to a valid tag or pin to a digest,
and ensure .skillsaw.yaml's referenced version matches it; to fix, run a
manifest inspect (docker/podman) or check GHCR tags to find the correct tag,
then update the SKILLSAW_IMAGE value and confirm .skillsaw.yaml contains the
same tag (or update .skillsaw.yaml to match) so both are consistent.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 941ab662-2342-4d07-bdc5-c7afeba27bac

📥 Commits

Reviewing files that changed from the base of the PR and between 1f24481 and 4bd665d.

📒 Files selected for processing (7)
  • .github/workflows/lint-plugins.yml
  • .github/workflows/lint-review.yml
  • .github/workflows/update-docs.yml
  • .skillsaw-badge.json
  • .skillsaw.yaml
  • Makefile
  • README.md
✅ Files skipped from review due to trivial changes (4)
  • .skillsaw.yaml
  • .github/workflows/lint-plugins.yml
  • .github/workflows/lint-review.yml
  • README.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • .skillsaw-badge.json

Comment thread Makefile
Comment thread README.md
@@ -1,5 +1,7 @@
# AI Helpers

[![skillsaw grade](https://img.shields.io/endpoint?url=https%3A%2F%2Fraw.githubusercontent.com%2Fopenshift-eng%2Fai-helpers%2Fmain%2F.skillsaw-badge.json)](https://skillsaw.org/)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will render after merging

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2026
@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 976149a into openshift-eng:main Jun 12, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants