Skip to content

Fix continue-session project path encoding - #535

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-eng:mainfrom
petr-muller:fix-continue-session-path-encoding
Jun 9, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift-eng:mainfrom
petr-muller:fix-continue-session-path-encoding

Conversation

@petr-muller

@petr-muller petr-muller commented Jun 9, 2026

Copy link
Copy Markdown
Member

Summary

  • Claude Code encodes project paths by replacing both / and . with -, but /ci:continue-session only replaced /
  • This caused --resume to fail for any project path containing dots (e.g. github.com in the path)
  • Fix: tr '/' '-'tr '/.' '--'

Test plan

  • Reproduced the bug: session copied with wrong path encoding, claude --resume failed
  • Fixed encoding, claude --resume succeeded

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores

    • CI plugin version bumped to 0.0.46.
  • Documentation

    • Updated continue-session documentation regarding local project path encoding.

@openshift-ci
openshift-ci Bot requested review from cblecker and jogeo June 9, 2026 16:33
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2026
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b61a8968-1933-4f9f-ac6c-7f6faec5b412

📥 Commits

Reviewing files that changed from the base of the PR and between 7ce876b and 84525ba.

📒 Files selected for processing (4)
  • .claude-plugin/marketplace.json
  • docs/index.html
  • plugins/ci/.claude-plugin/plugin.json
  • plugins/ci/commands/continue-session.md

Walkthrough

This PR bumps the CI plugin to version 0.0.46 across marketplace and plugin manifests, and updates the continue-session command documentation to change path encoding from replacing only / to replacing both / and . characters when constructing local Claude project directory paths.

Changes

CI Plugin Release and Documentation

Layer / File(s) Summary
Plugin version synchronization across manifests
.claude-plugin/marketplace.json, docs/index.html, plugins/ci/.claude-plugin/plugin.json
CI plugin version field is incremented to 0.0.46 in the root marketplace manifest, HTML documentation index, and the plugin's own manifest file.
Continue-session path encoding documentation update
plugins/ci/commands/continue-session.md
Step 7 instructions for copying sessions to local Claude projects are revised to encode paths by replacing both / and . characters with -, with example paths and command snippets updated accordingly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • openshift-eng/ai-helpers#381: The path encoding documentation update in Step 7 is directly related to the continue-session command documented in this PR.
  • openshift-eng/ai-helpers#341: Both PRs update the ci plugin version field in the manifest files (.claude-plugin/marketplace.json and plugins/ci/.claude-plugin/plugin.json).
  • openshift-eng/ai-helpers#427: Both PRs perform the same kind of version bump to the ci plugin across marketplace and manifest metadata files.

Suggested labels

ok-to-test, lgtm

Suggested reviewers

  • cblecker

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (2 errors)

Check name Status Explanation Resolution
No Real People Names In Style References ❌ Error File plugins/ci/commands/continue-session.md (new file in PR) contains real person's name 'stbenjam' in plugin command documentation example path. Replace the example file path /Users/stbenjam/git/github.com/my-repo with a generic placeholder like /Users/someone/projects/my-repo or similar.
No Assumed Git Remote Names ❌ Error File plugins/ci/commands/add-debug-wait.md uses hardcoded git remote names ("origin", "upstream") in commands without discovering them first (lines 81, 94, 96, 509). Discover remote names using git commands like git remote -v or git config --get-regexp before using them, or use --track with automatic tracking instead of hardcoded remote names.
✅ Passed checks (8 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change in the changeset—fixing the project path encoding logic in the continue-session command by updating how slashes and dots are replaced.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Git Push Safety Rules ✅ Passed PR contains only version updates and documentation fixes; no git push commands, force pushes, or main/master branch pushes are present in the changes.
No Untrusted Mcp Servers ✅ Passed PR introduces no MCP server installations. Only doc reference to official @modelcontextprotocol/server-atlassian (Atlassian/Anthropic partnership). Changes are version bumps and path encoding.
Ai-Helpers Overlap Detection ✅ Passed PR #535 fixes path encoding in ci:continue-session command. No overlapping functionality detected with other PRs or existing commands. Related session:save-session is complementary.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@petr-muller
petr-muller force-pushed the fix-continue-session-path-encoding branch from 1202189 to eaca204 Compare June 9, 2026 16:34
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2026
Claude Code encodes project paths by replacing both `/` and `.` with
`-`, but the command only replaced `/`. This caused `--resume` to fail
for any project path containing dots (e.g. `github.com`).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@petr-muller
petr-muller force-pushed the fix-continue-session-path-encoding branch from eaca204 to 84525ba Compare June 9, 2026 16:35
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2026
@stbenjam

stbenjam commented Jun 9, 2026

Copy link
Copy Markdown
Member

/lgtm

Thanks!

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2026
@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit c92de76 into openshift-eng:main Jun 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants