-
Notifications
You must be signed in to change notification settings - Fork 312
Fix 403 when posting lint comments on fork PRs #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
openshift-merge-bot
merged 5 commits into
openshift-eng:main
from
stbenjam:fix-lint-403-fork-prs
May 12, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d26115b
Fix 403 when posting lint review comments on fork PRs
stbenjam 1030a9c
Use two-workflow pattern for lint review comments on fork PRs
stbenjam f8e22f6
Update skillsaw action SHA to include two-workflow support
stbenjam 9d8dd00
Fix skillsaw action SHA
stbenjam 5f58193
Add comment explaining why lint review is a separate workflow
stbenjam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Separate workflow for posting lint review comments on PRs. | ||
| # The lint workflow runs with a read-only token (safe for fork PRs that | ||
| # execute custom linter rules via subprocess). This workflow triggers | ||
| # after it completes, downloads the report artifact, and posts comments | ||
| # with a write-capable token — without ever checking out untrusted code. | ||
| name: Lint Review | ||
|
|
||
| on: | ||
| workflow_run: | ||
| workflows: ["Lint Plugins"] | ||
| types: [completed] | ||
|
|
||
| jobs: | ||
| review: | ||
| if: github.event.workflow_run.event == 'pull_request' | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| pull-requests: write | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
|
|
||
| - name: Post review comments | ||
| uses: stbenjam/skillsaw/review@eee9ebea0f33517bfb3c4d0413471c5165becc7e # v0 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.