Skip to content

fix(jira): enforce full verification in jira:solve before committing - #330

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-eng:mainfrom
enxebre:jira-solve-enforce-verification
Feb 13, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift-eng:mainfrom
enxebre:jira-solve-enforce-verification

Conversation

@enxebre

@enxebre enxebre commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Strengthen verification step to use MUST language and add a hard gate before commit creation
  • Add failure handling: distinguish between changes-caused vs pre-existing failures
  • Explicitly forbid anti-patterns: per-package go test instead of make test, skipping make test due to unrelated lint failures, assuming targeted tests are sufficient

Test plan

  • Run /jira:solve on a test issue and verify make test is run (not per-package go test)
  • Introduce a deliberate test failure and verify the agent fixes it before committing

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation

    • Verification steps are now mandatory before commit creation, requiring full build, test, and verification runs where applicable.
    • Guidance added for handling failures—fix or document pre-existing issues—and progression is blocked until verification completes.
    • Clarified that skipping full test suites or testing only changed packages is not allowed; CI vs interactive flows and PR workflow wording updated.
  • Chores

    • Bumped Jira plugin version to 0.3.1.

@openshift-ci
openshift-ci Bot requested review from mrunalp and stbenjam February 13, 2026 00:34
@coderabbitai

coderabbitai Bot commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Docs updated for the Jira solve command to make verification steps mandatory (MUST), require running available Makefile targets (verify, build, test), add explicit failure categorization/handling, forbid partial/skip testing, and clarify CI vs interactive gating for commit/PR progression.

Changes

Cohort / File(s) Summary
Jira Solve Command Documentation
plugins/jira/commands/solve.md
Converted optional verification guidance to mandatory; requires make verify, make build, make test when targets exist; adds failure classification (pre-existing vs change-caused) and required actions; forbids skipping full test suites or testing only changed packages; clarifies --ci vs interactive flow and PR/Commit gating.
Plugin Version Manifests
plugins/jira/.claude-plugin/plugin.json, plugins/jira/..marketplace.json, docs/data.json
Bumped Jira plugin version from 0.3.0 to 0.3.1 across plugin manifest and docs entries; no functional code changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)
Check name Status Explanation Resolution
No Assumed Git Remote Names ❌ Error The plugins/jira/commands/solve.md file hardcodes the 'origin' remote name without discovering available remotes first. Add git remote -v discovery logic, remove hardcoded 'origin' default, update examples, and emphasize remote discovery before git operations.
✅ Passed checks (8 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly reflects the main change: enforcing full verification in the jira:solve command before committing, which aligns with all major modifications in the PR including increased verification requirements and failure handling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main
No Real People Names In Style References ✅ Passed Modified files contain no references to real people's names in style references or examples.
Git Push Safety Rules ✅ Passed Comprehensive repository search found no git push commands or unsafe git operations violating the Git Push Safety Rules.
No Untrusted Mcp Servers ✅ Passed This pull request contains no new MCP server installations from untrusted sources. The changes are limited to documentation updates for the jira:solve command, version bumps, and standard npm package script references only.
Ai-Helpers Overlap Detection ✅ Passed The PR modifies only the existing jira solve command with no duplicate functionality across the repository. Version bumps are consistently applied to metadata files.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
plugins/jira/commands/solve.md (1)

119-127: ⚠️ Potential issue | 🟡 Minor

Clarify PR target vs $2 remote to avoid contradictory instructions.

Line 126 hard-codes the PR target to enxebre/hypershift, while the synopsis and arguments describe $2 as the remote repo (default origin). Please reconcile: either make $2 the PR target or remove $2/update the synopsis and arguments to reflect a fixed target.

🔧 Possible wording fix
-  - Push the branch with all commits against the remote specified in argument $2
+  - Push the branch with all commits against the remote specified in argument $2
   - Create pull request with:
@@
-    - Always create the PR against enxebre/hypershift
+    - Create the PR against the same remote specified in argument $2 (default: origin)

Also applies to: 141-144

@enxebre
enxebre force-pushed the jira-solve-enforce-verification branch from 2dee4ad to 6b1c95b Compare February 13, 2026 00:44
Strengthen the verification step to explicitly forbid common shortcuts
like running per-package go test instead of make test. Add failure
handling guidance (fix vs note pre-existing) and a hard gate preventing
commit creation until all verification has passed.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@enxebre
enxebre force-pushed the jira-solve-enforce-verification branch from 6b1c95b to e956591 Compare February 13, 2026 00:49
@stbenjam

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2026
@openshift-ci

openshift-ci Bot commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit d0a8074 into openshift-eng:main Feb 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants