Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .claude-plugin/marketplace.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"name": "jira",
"source": "./plugins/jira",
"description": "A plugin to automate tasks with Jira",
"version": "0.0.3"
"version": "0.0.4"
},
{
"name": "ci",
Expand Down
4 changes: 2 additions & 2 deletions docs/data.json
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
"argument_hint": "",
"description": "Analyze a JIRA issue and create a pull request to solve it.",
"name": "solve",
"synopsis": "/jira:solve <jira-issue-id> [remote]"
"synopsis": "/jira:solve <jira-issue-id> [remote] [--ci]"
},
{
"argument_hint": "issue-id [--start-date YYYY-MM-DD] [--end-date YYYY-MM-DD]",
Expand Down Expand Up @@ -232,7 +232,7 @@
"name": "OCPBUGS Jira Conventions"
}
],
"version": "0.0.3"
"version": "0.0.4"
},
{
"commands": [
Expand Down
2 changes: 1 addition & 1 deletion plugins/jira/.claude-plugin/plugin.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "jira",
"description": "A plugin to automate tasks with Jira",
"version": "0.0.3",
"version": "0.0.4",
"author": {
"name": "github.com/openshift-eng"
}
Expand Down
23 changes: 14 additions & 9 deletions plugins/jira/commands/solve.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jira:solve

## Synopsis
```
/jira:solve <jira-issue-id> [remote]
/jira:solve <jira-issue-id> [remote] [--ci]
```

## Description
Expand Down Expand Up @@ -44,7 +44,8 @@ This command takes a JIRA URL, fetches the issue description and requirements, a
- Optional
- Steps to reproduce (for bugs)
- Expected vs actual behavior
- Ask the user for further issue grooming if the requried sections are missing
- If `--ci` flag ($3) is NOT set: Ask the user for further issue grooming if the required sections are missing
- If `--ci` flag ($3) IS set: Proceed with available information, making reasonable assumptions where needed

2. **Codebase Analysis**: Search and analyze relevant code:
- Find related files and functions
Expand All @@ -58,7 +59,8 @@ This command takes a JIRA URL, fetches the issue description and requirements, a

3. **Solution Implementation**:
- Think hard and create a detailed, step-by-step plan to implement this feature. Save it to spec-$1.md within the .work/jira/solve folder, for example .work/jira/solve/spec-OCPBUGS-12345.md
- Always ask the user to review the plan and give them the choice to modify it before start the implementation
- If `--ci` flag ($3) is NOT set: Ask the user to review the plan and give them the choice to modify it before starting the implementation
- If `--ci` flag ($3) IS set: Proceed immediately with implementation without waiting for approval
- Implement the plan:
- Make necessary code changes using Edit/MultiEdit tools
- Follow existing code patterns and conventions
Expand Down Expand Up @@ -118,16 +120,19 @@ This command takes a JIRA URL, fetches the issue description and requirements, a

6. **PR Description Review**:
- After creating the PR, display the PR URL and description to the user
- Ask the user: "Please review the PR description. Would you like me to update it? (yes/no)"
- If the user says yes or requests changes:
- Ask what changes they'd like to make
- Update the PR description using `gh pr edit {PR_NUMBER} --body "{new_description}"`
- Repeat this review step until the user is satisfied
- If the user says no or is satisfied, acknowledge and provide next steps
- If `--ci` flag ($3) is NOT set:
- Ask the user: "Please review the PR description. Would you like me to update it? (yes/no)"
- If the user says yes or requests changes:
- Ask what changes they'd like to make
- Update the PR description using `gh pr edit {PR_NUMBER} --body "{new_description}"`
- Repeat this review step until the user is satisfied
- If the user says no or is satisfied, acknowledge and provide next steps
- If `--ci` flag ($3) IS set: Skip the review step and proceed to completion


## Arguments:
- $1: The JIRA issue to solve (required)
- $2: The remote repository to push the branch. Defaults to "origin".
- $3: Optional `--ci` flag for non-interactive CI automation mode. When set, skips all user prompts and proceeds automatically.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

鈿狅笍 Potential issue | 馃煛 Minor

馃З Analysis chain

馃弫 Script executed:

fd -type f \( -name "solve*" -o -name "*solve*" \) plugins/jira/

Repository: openshift-eng/ai-helpers

Length of output: 238


馃弫 Script executed:

fd -e sh -e bash "solve" plugins/jira/

Repository: openshift-eng/ai-helpers

Length of output: 50


馃弫 Script executed:

ls -la plugins/jira/

Repository: openshift-eng/ai-helpers

Length of output: 428


馃弫 Script executed:

ls -la plugins/jira/commands/

Repository: openshift-eng/ai-helpers

Length of output: 859


馃弫 Script executed:

cat -n plugins/jira/commands/solve.md

Repository: openshift-eng/ai-helpers

Length of output: 9132


馃弫 Script executed:

ls -la plugins/jira/skills/

Repository: openshift-eng/ai-helpers

Length of output: 1079


馃弫 Script executed:

git ls-files | grep -i solve

Repository: openshift-eng/ai-helpers

Length of output: 98


馃弫 Script executed:

ls -la plugins/jira/.claude-plugin/ && cat plugins/jira/.claude-plugin/*

Repository: openshift-eng/ai-helpers

Length of output: 394


馃弫 Script executed:

head -100 plugins/jira/README.md

Repository: openshift-eng/ai-helpers

Length of output: 4455


馃弫 Script executed:

find . -name "*.md" -type f | xargs grep -l "Claude Code" | head -5

Repository: openshift-eng/ai-helpers

Length of output: 150


馃弫 Script executed:

grep -A 20 -B 5 "argument\|positional\|parameter\|\$[0-9]" ./PLUGINS.md | head -80

Repository: openshift-eng/ai-helpers

Length of output: 2936


Clarify how the --ci flag can be used with the default remote.

The documentation indicates that $2 (remote) defaults to "origin" and $3 is the optional --ci flag. However, it's unclear whether users can run /jira:solve OCPBUGS-12345 --ci (omitting the remote) or if they must explicitly specify the remote (e.g., /jira:solve OCPBUGS-12345 origin --ci).

Add a usage example that demonstrates using the --ci flag with the default remote to clarify this behavior for users.

馃 Prompt for AI Agents
In `@plugins/jira/commands/solve.md` at line 136, Update the docs for the
/jira:solve command to explicitly show that the remote ($2) defaults to "origin"
and that the --ci flag ($3) can be passed without specifying the remote; add a
concise usage example such as "/jira:solve OCPBUGS-12345 --ci" (and optionally
show the equivalent with explicit remote "/jira:solve OCPBUGS-12345 origin
--ci") next to the $3 description so readers clearly see the default-remote
behavior.


The command will provide progress updates and create a comprehensive solution addressing all requirements from the JIRA issue.