Skip to content

add name to Service in OpenShift template #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eranco74 merged 1 commit into from
Jul 21, 2025
Merged

add name to Service in OpenShift template #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,6 @@ objects:
app: assisted-service-mcp
ports:
- protocol: TCP
name: assisted-service-mcp
port: ${{SERVICE_PORT}}
targetPort: ${{SERVICE_PORT}}
Comment on lines 100 to 103
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Port name exceeds the Kubernetes 15-character limit – monitoring may still fail

assisted-service-mcp is 20 characters long, but ServicePort.name must be an IANA SVC_NAME (lower-case alphanumerics + ‘-’) of ≤ 15 characters. Many clusters will reject or silently trim this, breaking both monitoring and DNS-based service discovery.

Proposed fix – keep it short (e.g. http or api):

-      - protocol: TCP
-        name: assisted-service-mcp
+      - name: http
+        protocol: TCP

Please also update any Prometheus scrape configs / consumers that reference the port name.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- protocol: TCP
name: assisted-service-mcp
port: ${{SERVICE_PORT}}
targetPort: ${{SERVICE_PORT}}
- name: http
protocol: TCP
port: ${{SERVICE_PORT}}
targetPort: ${{SERVICE_PORT}}
🤖 Prompt for AI Agents 
In template.yaml around lines 100 to 103, the port name 'assisted-service-mcp'
exceeds Kubernetes' 15-character limit for ServicePort names, which can cause
monitoring and service discovery failures. Rename the port to a shorter valid
name such as 'http' or 'api' that is lowercase alphanumeric with hyphens and no
longer than 15 characters. Also, update any Prometheus scrape configurations or
other consumers that reference this port name to use the new shorter name.