Skip to content

MGMT-20908: Add support for the OAuth authorization code flow#3

Closed
jhernand wants to merge 1 commit intoopenshift-assisted:masterfrom
jhernand:add_support_for_the_auth_code_flow
Closed

MGMT-20908: Add support for the OAuth authorization code flow#3
jhernand wants to merge 1 commit intoopenshift-assisted:masterfrom
jhernand:add_support_for_the_auth_code_flow

Conversation

@jhernand
Copy link
Copy Markdown
Collaborator

@jhernand jhernand commented Jun 24, 2025

Currently the server requires the offine token in the OFFLINE_TOKEN environment variable, or in a request header. But use of offline tokens is deprected, and will be removed in the future. To avoid using them this patch adds an optional mechanism to use the OAuth authorization code flow, intended for use when the server is executed locally by the user. When the server starts it checks if the USE_AUTHORIZATION_CODE_FLOW environment variable is set to true. If it is then the authorization URL will be opened with the local browser, so that the user can provide the credentials. Then the authorization server will send the authorization code to the /oauth/callback endpoint, and the MCP sever will exchange that code for the refresh and access tokens. The refresh token is then used as it was the offline token.

Related: https://issues.redhat.com/browse/MGMT-20908

@jhernand
MGMT-20908: Add support for the OAuth authorization code flow
f57899e 
Currently the server requires the offine token in the `OFFLINE_TOKEN`
environment variable, or in a request header. But use of offline tokens
is deprected, and will be removed in the future. To avoid using them
this patch adds an optional mechanism to use the OAuth authorization
code flow, intended for use when the server is executed locally by the
user. When the server starts it checks if the
`USE_AUTHORIZATION_CODE_FLOW` environment variable is set to `true`. If
it is then the authorization URL will be opened with the local browser,
so that the user can provide the credentials. Then the authorization
server will send the authorization code to the `/oauth/callback`
endpoint, and the MCP sever will exchange that code for the refresh and
access tokens. The refresh token is then used as it was the offline
token.

Related: https://issues.redhat.com/browse/MGMT-20908
Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 24, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 24, 2025 •
edited by openshift-ci Bot
Loading

@jhernand: This pull request references MGMT-20908 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Currently the server requires the offine token in the OFFLINE_TOKEN environment variable, or in a request header. But use of offline tokens is deprected, and will be removed in the future. To avoid using them this patch adds an optional mechanism to use the OAuth authorization code flow, intended for use when the server is executed locally by the user. When the server starts it checks if the USE_AUTHORIZATION_CODE_FLOW environment variable is set to true. If it is then the authorization URL will be opened with the local browser, so that the user can provide the credentials. Then the authorization server will send the authorization code to the /oauth/callback endpoint, and the MCP sever will exchange that code for the refresh and access tokens. The refresh token is then used as it was the offline token.

Related: https://issues.redhat.com/browse/MGMT-20908

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jhernand

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 24, 2025

Welcome @jhernand! It looks like this is your first PR to openshift-assisted/assisted-service-mcp 🎉

@jhernand jhernand marked this pull request as draft June 24, 2025 20:15
@openshift-ci openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 24, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 24, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jhernand
Copy link
Copy Markdown
Collaborator Author

jhernand commented Jun 25, 2025

Replaced by #5 .

@jhernand jhernand closed this Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jhernand @openshift-ci-robot