ACM-27599: Installation wizard blocked due to AgentClusterInstallValidator by LiorSoffer · Pull Request #3372 · openshift-assisted/assisted-installer-ui

LiorSoffer · 2026-01-29T14:57:48Z

https://issues.redhat.com/browse/ACM-27599

Summary by CodeRabbit

Refactor
- Forms now advance directly to the next step without requiring an explicit submit action.
- OpenShift version selection logic simplified: defaults are applied for new deployments and edit mode shows a static, read-only version display.
- CPU architecture and version calculations now update more consistently when the selected OpenShift version changes.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2026-01-29T14:58:15Z

📝 Walkthrough

Walkthrough

Removed agentClusterInstall and forceOpenshiftVersion props from cluster deployment form components, simplified OpenShift version selection to use only values.openshiftVersion, and removed submission-on-next dirty/submission checks so the form always advances to the next step.

Changes

Cohort / File(s)	Summary
Cluster Deployment Form Wrapper `libs/ui-lib/lib/cim/components/ClusterDeployment/clusterDetails/ClusterDeploymentDetailsForm.tsx`	Removed submission-on-next logic that checked dirty/submission state; now always calls `onNext`. Removed `agentClusterInstall` prop and `getSelectedVersion` import; version lookup simplified to `values.openshiftVersion`.
Form Fields Component `libs/ui-lib/lib/cim/components/ClusterDeployment/clusterDetails/ClusterDetailsFormFields.tsx`	Removed `forceOpenshiftVersion` prop and its usage. Default OpenShift version now initialized only when not `isEditFlow`, setting `customOpenshiftSelect`, `openshiftVersion`, and `networkType`. Edit-flow now shows static OpenShift version text from `allVersions` or raw value.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

MGMT-21014: Impossible to choose n+1 or n-4 version - only n, n+1 and n+2 are shown in OCP version dropdown #3049 — Changes to OpenShift version selection and related form props (adds allVersions and custom version selection UI).
MGMT-20076: Support external platform in Assisted-installer Kube API #3151 — Modifies the same cluster-details components and removes forceOpenshiftVersion handling.

Suggested labels

lgtm, approved

Suggested reviewers

ElayAharoni
jgyselov

Poem

A rabbit hops through tangled code, 🐰
Props pruned clean from every tree,
Versions chosen by the user’s seed,
Steps leap forward, no checks to impede,
A tiny hop — simplicity freed. 🌱

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title references ticket ACM-27599 and mentions the specific blocker (AgentClusterInstallValidator). It accurately reflects the core change: removing the agentClusterInstall prop dependency to unblock the installation wizard.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In
`@libs/ui-lib/lib/cim/components/ClusterDeployment/clusterDetails/ClusterDetailsFormFields.tsx`:
- Around line 146-149: When rendering the OpenShift version in the
StaticTextField for the edit flow, use the form's current value as a fallback
when forceOpenshiftVersion is undefined: update the JSX that shows the version
(inside the StaticTextField used when isEditFlow || forceOpenshiftVersion) to
render forceOpenshiftVersion ?? values.openshiftVersion (or equivalent) so that
when isEditFlow is true and forceOpenshiftVersion is not set the displayed
version comes from values.openshiftVersion; ensure you reference the existing
symbols isEditFlow, forceOpenshiftVersion, StaticTextField and
values.openshiftVersion so the change is localized to that component.

libs/ui-lib/lib/cim/components/ClusterDeployment/clusterDetails/ClusterDetailsFormFields.tsx

openshift-ci-robot · 2026-01-29T15:03:44Z

@LiorSoffer: This pull request references ACM-27599 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/ACM-27599

Summary by CodeRabbit

Bug Fixes

Enhanced edit mode behavior: OpenShift version now displays as read-only text instead of a dropdown when editing clusters.

Fixed form to preserve existing values and prevent unintended resets during cluster editing.

Improved form workflow logic to properly handle both cluster creation and editing scenarios.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-02-01T13:32:33Z

@LiorSoffer: This pull request references ACM-27599 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/ACM-27599

Summary by CodeRabbit

Refactor

Simplified form navigation for cluster deployment—forms now advance directly without prior submission

Streamlined OpenShift version selection logic and display in cluster configuration workflows, particularly in edit mode

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In
`@libs/ui-lib/lib/cim/components/ClusterDeployment/clusterDetails/ClusterDetailsFormFields.tsx`:
- Around line 144-149: In ClusterDetailsFormFields.tsx inside the isEditFlow
branch (the StaticTextField rendering for name="openshiftVersion"), ensure
there's a space between the translated label t('ai:OpenShift') and the version
text (the expression using allVersions.find(...) || values.openshiftVersion);
update the rendering so the translated string and the version are separated
(e.g., append a trailing space to the translation or insert a literal space
between the two expressions) to prevent "OpenShift4.15" rendering.

libs/ui-lib/lib/cim/components/ClusterDeployment/clusterDetails/ClusterDetailsFormFields.tsx

…sters Signed-off-by: Lior Soffer <lsoffer@redhat.com>

openshift-ci-robot · 2026-02-01T13:39:35Z

@LiorSoffer: This pull request references ACM-27599 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/ACM-27599

Summary by CodeRabbit

Refactor

Forms now advance directly to the next step without requiring an explicit submit action.

OpenShift version selection logic simplified: defaults are applied for new deployments and edit mode shows a static, read-only version display.

CPU architecture and version calculations now update more consistently when the selected OpenShift version changes.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In
`@libs/ui-lib/lib/cim/components/ClusterDeployment/clusterDetails/ClusterDeploymentDetailsForm.tsx`:
- Around line 49-56: The handleOnNext callback currently only calls
goToNextStep, skipping Formik submission; update ClusterDeploymentDetailsForm's
handleOnNext to invoke Formik's submitForm (from
useFormikContext<ClusterDetailsValues>()) instead of directly navigating so the
form's onSubmit/onSaveDetails runs and values persist, e.g., call submitForm()
(or submitForm() then await confirmation) within handleOnNext rather than only
calling goToNextStep.

🧹 Nitpick comments (1)

libs/ui-lib/lib/cim/components/ClusterDeployment/clusterDetails/ClusterDeploymentDetailsForm.tsx (1)
33-40: Unused agentClusterInstall prop in type definition.

The agentClusterInstall prop is defined in ClusterDeploymentDetailsFormProps (line 36) but is not destructured or used in the ClusterDeploymentDetailsForm component (lines 92-98). This appears to be leftover from the refactor.
♻️ Proposed fix to remove unused prop
 type ClusterDeploymentDetailsFormProps = {
   clusterImages: ClusterImageSetK8sResource[];
   clusterDeployment?: ClusterDeploymentK8sResource;
-  agentClusterInstall?: AgentClusterInstallK8sResource;
   extensionAfter?: ClusterDetailsFormFieldsProps['extensionAfter'];
   isNutanix?: boolean;
   osImages?: OsImage[];
 };
After removing the prop, also remove the unused import on line 12:
 import {
-  AgentClusterInstallK8sResource,
   ClusterDeploymentK8sResource,
   OsImage,
 } from '../../../types';

.../ui-lib/lib/cim/components/ClusterDeployment/clusterDetails/ClusterDeploymentDetailsForm.tsx

openshift-ci-robot · 2026-02-04T10:38:54Z

@LiorSoffer: This pull request references ACM-27599 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/ACM-27599

Summary by CodeRabbit

Refactor

Forms now advance directly to the next step without requiring an explicit submit action.

OpenShift version selection logic simplified: defaults are applied for new deployments and edit mode shows a static, read-only version display.

CPU architecture and version calculations now update more consistently when the selected OpenShift version changes.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-02-09T15:35:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgyselov, LiorSoffer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jgyselov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LiorSoffer · 2026-02-09T15:39:06Z

/cherry-pick releases/v2.14-cim
/cherry-pick releases/v2.15-cim
/cherry-pick releases/v2.16-cim
/cherry-pick releases/v2.17-cim

openshift-cherrypick-robot · 2026-02-09T15:39:10Z

@LiorSoffer: once the present PR merges, I will cherry-pick it on top of releases/v2.14-cim, releases/v2.15-cim, releases/v2.16-cim, releases/v2.17-cim in new PRs and assign them to you.

Details

In response to this:

/cherry-pick releases/v2.14-cim
/cherry-pick releases/v2.15-cim
/cherry-pick releases/v2.16-cim
/cherry-pick releases/v2.17-cim

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2026-02-09T19:14:27Z

@LiorSoffer: #3372 failed to apply on top of branch "releases/v2.14-cim":

Applying: fix: prevent form submission on cluster details step for existing clusters
Using index info to reconstruct a base tree...
A	libs/ui-lib/lib/cim/components/ClusterDeployment/clusterDetails/ClusterDeploymentDetailsForm.tsx
A	libs/ui-lib/lib/cim/components/ClusterDeployment/clusterDetails/ClusterDetailsFormFields.tsx
Falling back to patching base and 3-way merge...
Auto-merging libs/ui-lib/lib/cim/components/ClusterDeployment/ClusterDetailsFormFields.tsx
Auto-merging libs/ui-lib/lib/cim/components/ClusterDeployment/ClusterDeploymentDetailsForm.tsx
CONFLICT (content): Merge conflict in libs/ui-lib/lib/cim/components/ClusterDeployment/ClusterDeploymentDetailsForm.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 fix: prevent form submission on cluster details step for existing clusters

Details

In response to this:

/cherry-pick releases/v2.14-cim
/cherry-pick releases/v2.15-cim
/cherry-pick releases/v2.16-cim
/cherry-pick releases/v2.17-cim

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2026-02-09T19:14:39Z

@LiorSoffer: #3372 failed to apply on top of branch "releases/v2.14-cim":

Applying: fix: prevent form submission on cluster details step for existing clusters
Using index info to reconstruct a base tree...
A	libs/ui-lib/lib/cim/components/ClusterDeployment/clusterDetails/ClusterDeploymentDetailsForm.tsx
A	libs/ui-lib/lib/cim/components/ClusterDeployment/clusterDetails/ClusterDetailsFormFields.tsx
Falling back to patching base and 3-way merge...
Auto-merging libs/ui-lib/lib/cim/components/ClusterDeployment/ClusterDetailsFormFields.tsx
Auto-merging libs/ui-lib/lib/cim/components/ClusterDeployment/ClusterDeploymentDetailsForm.tsx
CONFLICT (content): Merge conflict in libs/ui-lib/lib/cim/components/ClusterDeployment/ClusterDeploymentDetailsForm.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 fix: prevent form submission on cluster details step for existing clusters

Details

In response to this:

/cherry-pick releases/v2.14-cim
/cherry-pick releases/v2.15-cim
/cherry-pick releases/v2.16-cim
/cherry-pick releases/v2.17-cim

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2026-02-09T19:15:22Z

@LiorSoffer: #3372 failed to apply on top of branch "releases/v2.15-cim":

Applying: fix: prevent form submission on cluster details step for existing clusters
Using index info to reconstruct a base tree...
A	libs/ui-lib/lib/cim/components/ClusterDeployment/clusterDetails/ClusterDeploymentDetailsForm.tsx
A	libs/ui-lib/lib/cim/components/ClusterDeployment/clusterDetails/ClusterDetailsFormFields.tsx
Falling back to patching base and 3-way merge...
Auto-merging libs/ui-lib/lib/cim/components/ClusterDeployment/ClusterDetailsFormFields.tsx
Auto-merging libs/ui-lib/lib/cim/components/ClusterDeployment/ClusterDeploymentDetailsForm.tsx
CONFLICT (content): Merge conflict in libs/ui-lib/lib/cim/components/ClusterDeployment/ClusterDeploymentDetailsForm.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 fix: prevent form submission on cluster details step for existing clusters

Details

In response to this:

/cherry-pick releases/v2.14-cim
/cherry-pick releases/v2.15-cim
/cherry-pick releases/v2.16-cim
/cherry-pick releases/v2.17-cim

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2026-02-09T19:16:27Z

@LiorSoffer: new pull request created: #3390

Details

In response to this:

/cherry-pick releases/v2.14-cim
/cherry-pick releases/v2.15-cim
/cherry-pick releases/v2.16-cim
/cherry-pick releases/v2.17-cim

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2026-02-09T19:17:14Z

@LiorSoffer: new pull request created: #3391

Details

In response to this:

/cherry-pick releases/v2.14-cim
/cherry-pick releases/v2.15-cim
/cherry-pick releases/v2.16-cim
/cherry-pick releases/v2.17-cim

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot requested review from ElayAharoni and jgyselov January 29, 2026 14:57

openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 29, 2026

coderabbitai bot reviewed Jan 29, 2026

View reviewed changes

libs/ui-lib/lib/cim/components/ClusterDeployment/clusterDetails/ClusterDetailsFormFields.tsx Outdated Show resolved Hide resolved

jgyselov changed the title ~~fix: prevent form submission on cluster details step for existing clu…~~ ACM-27599: Installation wizard blocked due to AgentClusterInstallValidator Jan 29, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 29, 2026

LiorSoffer force-pushed the versionBug branch from 2294381 to 3144f96 Compare February 1, 2026 13:29

openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 1, 2026

coderabbitai bot reviewed Feb 1, 2026

View reviewed changes

libs/ui-lib/lib/cim/components/ClusterDeployment/clusterDetails/ClusterDetailsFormFields.tsx Show resolved Hide resolved

fix: prevent form submission on cluster details step for existing clu…

5babbc6

…sters Signed-off-by: Lior Soffer <lsoffer@redhat.com>

LiorSoffer force-pushed the versionBug branch from 3144f96 to 5babbc6 Compare February 1, 2026 13:36

coderabbitai bot reviewed Feb 1, 2026

View reviewed changes

.../ui-lib/lib/cim/components/ClusterDeployment/clusterDetails/ClusterDeploymentDetailsForm.tsx Show resolved Hide resolved

LiorSoffer closed this Feb 4, 2026

LiorSoffer deleted the versionBug branch February 4, 2026 10:02

LiorSoffer restored the versionBug branch February 4, 2026 10:38

LiorSoffer reopened this Feb 4, 2026

jgyselov approved these changes Feb 9, 2026

View reviewed changes

openshift-ci bot assigned jgyselov Feb 9, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2026

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2026

openshift-merge-bot bot merged commit 04fc936 into openshift-assisted:master Feb 9, 2026
19 checks passed

openshift-cherrypick-robot mentioned this pull request Feb 9, 2026

[releases/v2.16-cim] ACM-27599: Installation wizard blocked due to AgentClusterInstallValidator #3390

Merged

openshift-cherrypick-robot mentioned this pull request Feb 9, 2026

[releases/v2.17-cim] ACM-27599: Installation wizard blocked due to AgentClusterInstallValidator #3391

Merged

openshift-ci bot mentioned this pull request Feb 10, 2026

[releases/v2.14-cim] ACM-27599: Installation wizard blocked due to AgentClusterInstallValidator #3394

Merged

LiorSoffer mentioned this pull request Feb 10, 2026

[releases/v2.15-cim] ACM-27599: Installation wizard blocked due to AgentClusterInstallValidator #3395

Merged

Conversation

LiorSoffer commented Jan 29, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 29, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 29, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Feb 1, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 1, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 4, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-ci bot commented Feb 9, 2026

Uh oh!

LiorSoffer commented Feb 9, 2026

Uh oh!

openshift-cherrypick-robot commented Feb 9, 2026

Uh oh!

Uh oh!

openshift-cherrypick-robot commented Feb 9, 2026

Uh oh!

openshift-cherrypick-robot commented Feb 9, 2026

Uh oh!

openshift-cherrypick-robot commented Feb 9, 2026

Uh oh!

openshift-cherrypick-robot commented Feb 9, 2026

Uh oh!

openshift-cherrypick-robot commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

LiorSoffer commented Jan 29, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 29, 2026 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jan 29, 2026 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Feb 1, 2026 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Feb 1, 2026 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Feb 4, 2026 •

edited by openshift-ci bot

Loading