MGMT-20673: Improve OpenShift AI bundle requirements tooltip#3352
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@yoavsc0302: This pull request references MGMT-20673 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
📝 WalkthroughWalkthroughUpdates the openshift-ai bundle specification to add a Changes
Sequence Diagram(s)(omitted — change is a small content/spec update with no new multi-component control flow) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
bot
added
the
size/XS
|
@yoavsc0302: This pull request references MGMT-20673 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
yoavsc0302
force-pushed
the
MGMT-20673/Openshift-AI-bundle-requirements-tooltip-doesn't-display-requirements
branch
from
2e2bd2c to
223bca2
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
@libs/ui-lib/lib/ocm/components/clusterConfiguration/operators/bundleSpecs.tsx:
- Around line 40-41: Replace the hardcoded "2025" in the docsLink value with a
dynamic year by importing getYearForAssistedInstallerDocumentationLink from
docs_links.ts and using it in a template literal for the URL; update the import
list at the top of the file to include
getYearForAssistedInstallerDocumentationLink and change the docsLink string (in
the bundleSpecs entry) to use
'.../assisted_installer_for_openshift_container_platform/${getYearForAssistedInstallerDocumentationLink()}/html/...#openshift-ai-bundle_customizing-with-bundles-and-operators'.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
libs/ui-lib/lib/ocm/components/clusterConfiguration/operators/bundleSpecs.tsx
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: ammont82
Repo: openshift-assisted/assisted-installer-ui PR: 3101
File: libs/ui-lib/lib/common/config/docs_links.ts:203-221
Timestamp: 2025-08-11T06:07:38.056Z
Learning: The MetalLB, OADP, Cluster Observability, and NUMA Resources operators in the virtualization bundle don't require version fallback logic in their documentation link functions (getMetalLbLink, getOadpLink, getClusterObservabilityLink, getNumaResourcesLink) in libs/ui-lib/lib/common/config/docs_links.ts, unlike some other operators like LSO and NVIDIA GPU.
📚 Learning: 2025-08-11T06:07:38.056Z
Learnt from: ammont82
Repo: openshift-assisted/assisted-installer-ui PR: 3101
File: libs/ui-lib/lib/common/config/docs_links.ts:203-221
Timestamp: 2025-08-11T06:07:38.056Z
Learning: The MetalLB, OADP, Cluster Observability, and NUMA Resources operators in the virtualization bundle don't require version fallback logic in their documentation link functions (getMetalLbLink, getOadpLink, getClusterObservabilityLink, getNumaResourcesLink) in libs/ui-lib/lib/common/config/docs_links.ts, unlike some other operators like LSO and NVIDIA GPU.
Applied to files:
libs/ui-lib/lib/ocm/components/clusterConfiguration/operators/bundleSpecs.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: circular-deps
- GitHub Check: format
- GitHub Check: tests
- GitHub Check: unit-tests
- GitHub Check: lint
- GitHub Check: translation-files
🔇 Additional comments (3)
libs/ui-lib/lib/ocm/components/clusterConfiguration/operators/bundleSpecs.tsx (3)
7-7: LGTM! Optional docsLink field appropriately extends BundleSpec.The optional field maintains backward compatibility with existing bundles that don't require documentation links.
33-33: LGTM! Clear GPU recommendation message.The message effectively communicates that GPUs enhance AI/ML workload performance without making them a hard requirement.
34-37: LGTM! Clear explanation of automatic operator installation.The message effectively communicates that GPU operators are automatically installed based on hardware detection, which helps set user expectations during cluster creation.
libs/ui-lib/lib/ocm/components/clusterConfiguration/operators/bundleSpecs.tsx
Outdated
Show resolved
Hide resolved
|
@yoavsc0302: This pull request references MGMT-20673 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
- Add message that GPUs are recommended for optimal AI/ML workload performance - Add link to official Red Hat documentation for detailed requirements The tooltip now provides users with clear guidance when selecting the OpenShift AI bundle during cluster creation.
yoavsc0302
force-pushed
the
MGMT-20673/Openshift-AI-bundle-requirements-tooltip-doesn't-display-requirements
branch
from
cff02c8 to
816d302
Compare
|
@yoavsc0302: This pull request references MGMT-20673 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ammont82, yoavsc0302 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
/test images |
openshift-merge-bot
bot
merged commit 9878a25
into
openshift-assisted:master
3 participants
The tooltip now provides users with clear guidance when selecting the OpenShift AI bundle during cluster creation.
Summary by CodeRabbit
New Features
Enhancements
✏️ Tip: You can customize this high-level summary in your review settings.