Skip to content

MGMT-22463: Mass hostname change preview is not correctly aligned #3344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Jan 14, 2026
Merged

MGMT-22463: Mass hostname change preview is not correctly aligned #3344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 43 additions & 37 deletions libs/ui-lib/lib/common/components/hosts/MassChangeHostnameModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {
Button,
ButtonType,
ButtonVariant,
Content,
Form,
HelperText,
HelperTextItem,
Expand Down Expand Up @@ -56,6 +57,7 @@ const getNewHostnames = (
const [changeEnabled, reason] = canChangeHostname(h);
const hostnameRes = {
newHostname: changeEnabled ? templateToHostname(index, values) : undefined,
oldHostname: getHostname(h),
reason: changeEnabled ? undefined : reason,
};
if (changeEnabled) {
Expand Down Expand Up @@ -176,6 +178,7 @@ const MassChangeHostnameForm = ({

const newHostnames = getNewHostnames(values, selectedHosts, canChangeHostname);
const { t } = useTranslation();

return (
<Form onSubmit={handleSubmit}>
<ModalBody>
Expand Down Expand Up @@ -206,44 +209,47 @@ const MassChangeHostnameForm = ({
</StackItem>
<StackItem>
{t('ai:Preview')}
<div className="hostname-preview">
{selectedHosts.map((h, index) => {
const { newHostname, reason } = newHostnames[index];
return (
<Split key={h.id || index} hasGutter>
<SplitItem className="hostname-column">
<div className="hostname-column__text">
<strong>{getHostname(h)}</strong>
</div>
</SplitItem>
<SplitItem>
<div>
<strong>{'>'}</strong>
</div>
</SplitItem>
<SplitItem isFilled>
{reason ? (
<Popover
aria-label={t('ai:Cannot change hostname popover')}
headerContent={<div>{t('ai:Hostname cannot be changed')}</div>}
bodyContent={<div>{reason}</div>}
<Split className="hostname-preview" hasGutter>
<SplitItem className="hostname-column">
{newHostnames.map((host, i) => (
<div className="hostname-column__text" key={`old-hostname-${i}`}>
<strong>{host.oldHostname}</strong>
</div>
))}
</SplitItem>
<SplitItem>
{newHostnames.map((_, i) => (
<div key={`divider-${i}`}>
<strong>{'>'}</strong>
</div>
))}
</SplitItem>
<SplitItem>
{newHostnames.map((host, i) => (
<div key={`new-hostname-${i}`}>
{host.reason ? (
<Popover
aria-label={t('ai:Cannot change hostname popover')}
headerContent={<div>{t('ai:Hostname cannot be changed')}</div>}
bodyContent={<div>{host.reason}</div>}
>
<Button
variant="link"
icon={<InfoCircleIcon color={blueInfoColor.value} />}
isInline
>
<Button
variant="link"
icon={<InfoCircleIcon color={blueInfoColor.value} />}
isInline
>
{t('ai:Not changeable')}
</Button>
</Popover>
) : (
newHostname || t('ai:New hostname will appear here...')
)}
</SplitItem>
</Split>
);
})}
</div>
{t('ai:Not changeable')}
</Button>
</Popover>
) : (
<Content>
{host.newHostname || t('ai:New hostname will appear here...')}
</Content>
)}
</div>
))}
</SplitItem>
</Split>
</StackItem>
<StackItem>
<ModalProgress
Expand Down
Loading