[master] use old release process#3333
Conversation
WalkthroughModified GitHub Actions release workflow: downgraded checkout and setup-node actions from v4 to v3, removed workflow-level permissions, added git configuration step, introduced NPM_AUTH_TOKEN environment variable for scoped registry authentication, removed explicit Yarn registry config, and added retry delay loop post-publish verification for eventual consistency. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgyselov, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/release.yaml (1)
1-86: Concern: Intentional downgrade conflicts with GitHub Actions deprecation policy.The PR title indicates this is intentionally using an "old release process," but the downgrades to v3 actions conflict with GitHub's deprecation warnings. While there may be valid reasons for reverting (perhaps v4 actions introduced breaking changes), this approach creates technical debt and risks future workflow failures.
Consider:
- Documenting why the revert to v3 is necessary in the PR description or workflow comments
- Creating a follow-up issue to investigate and resolve the root cause requiring v3 actions
- Adding workflow comments explaining the version pinning to prevent future "upgrade" attempts
Would you like me to help document the specific issues with v4 actions that necessitated this revert, or open a tracking issue for modernizing this workflow?
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/release.yaml(3 hunks)
🧰 Additional context used
🪛 actionlint (1.7.9)
.github/workflows/release.yaml
24-24: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
50-50: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: format
- GitHub Check: lint
- GitHub Check: unit-tests
- GitHub Check: circular-deps
- GitHub Check: translation-files
- GitHub Check: tests
🔇 Additional comments (1)
.github/workflows/release.yaml (1)
45-49: LGTM: Git configuration properly set for automated commits.The git configuration step correctly sets up user identity for the subsequent version bump commits using GitHub's standard bot email format.
a7da983
into
openshift-assisted:master
Returning to a working release process.
This is an automated cherry-pick of #3288
/assign jgyselov
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.