Skip to content

MGMT-22161: Restrict platform options for SNO clusters #3262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Nov 13, 2025
Merged

MGMT-22161: Restrict platform options for SNO clusters #3262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion libs/ui-lib/lib/common/components/clusterConfiguration/ControlPlaneNodesDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,10 @@ import {
} from '@patternfly/react-core';
import { useTranslation } from '../../hooks/use-translation-wrapper';
import { getFieldId, StaticField } from '../..';
import { useField } from 'formik';
import toNumber from 'lodash-es/toNumber';
import OcmTNADisclaimer from './OcmTNADisclaimer';
import { ClusterDetailsValues } from '../clusterWizard';
import { useField, useFormikContext } from 'formik';

const isItemEnabled = (value: number, allowHighlyAvailable?: boolean, allowTNA?: boolean) => {
switch (value) {
Expand Down Expand Up @@ -44,6 +45,7 @@ const ControlPlaneNodesDropdown = ({
}) => {
const { t } = useTranslation();
const [{ name, value: selectedValue }, , { setValue }] = useField<number>('controlPlaneCount');
const { setFieldValue } = useFormikContext<ClusterDetailsValues>();
const [controlPlanelOpen, setControlPlanelOpen] = React.useState(false);
const fieldId = getFieldId(name, 'input');

Expand Down Expand Up @@ -85,6 +87,13 @@ const ControlPlaneNodesDropdown = ({
e?: React.MouseEvent<Element, MouseEvent>,
value?: string | number,
) => {
if (value === 1) {
setFieldValue('userManagedNetworking', true);
setFieldValue('platform', 'none');
} else {
setFieldValue('userManagedNetworking', false);
setFieldValue('platform', 'baremetal');
}
setValue(toNumber(value));
setControlPlanelOpen(false);
};
Expand Down
14 changes: 10 additions & 4 deletions libs/ui-lib/lib/common/components/clusterConfiguration/ExternalPlatformsDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,19 @@ export const getPlatforms = (t: TFunction): { [key in PlatformType]: string } =>
export const ExternalPlatformsDropdown = ({ isDisabled }: { isDisabled: boolean }) => {
const [isOpen, setIsOpen] = React.useState(false);
const [{ value }, , { setValue }] = useField<PlatformType>('platform');
const { setFieldValue } = useFormikContext<ClusterDetailsValues>();
const { setFieldValue, values } = useFormikContext<ClusterDetailsValues>();
const { t } = useTranslation();

const platforms = getPlatforms(t);

const isSNO = values.controlPlaneCount === 1;
const options = Object.entries(platforms)
.filter(([key]) => key !== 'none')
.filter(([key]) => {
if (isSNO) {
return key === 'none' || key === 'vsphere' || key === 'external';
} else {
return key !== 'none';
}
})
.map(([platform, label]) => (
<DropdownItem
key={platform}
Expand All @@ -44,7 +50,7 @@ export const ExternalPlatformsDropdown = ({ isDisabled }: { isDisabled: boolean
setValue(value as PlatformType);
setIsOpen(false);

if (value === 'external') {
if (value === 'external' || values.controlPlaneCount === 1) {
setFieldValue('userManagedNetworking', true);
} else {
setFieldValue('userManagedNetworking', false);
Expand Down
Loading