Skip to content

[release-4.20]OCPBUGS-62717: Include assisted disconnected UI image in release payload#3189

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-assisted:release-4.20from
pawanpinjarkar:cherrypick-add-label
Oct 21, 2025
Merged

[release-4.20]OCPBUGS-62717: Include assisted disconnected UI image in release payload#3189
openshift-merge-bot[bot] merged 1 commit intoopenshift-assisted:release-4.20from
pawanpinjarkar:cherrypick-add-label

Conversation

@pawanpinjarkar
Copy link
Contributor

Manual cherrypick of #3188

@openshift-ci openshift-ci bot requested review from batzionb and rawagner October 3, 2025 23:05
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 3, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 3, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pawanpinjarkar pawanpinjarkar changed the title [release-4.20]: Include assisted disconnected UI image in release payload [release-4.20]OCPBUGS-62717: Include assisted disconnected UI image in release payload Oct 3, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 3, 2025
@openshift-ci-robot
Copy link

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-62717, which is invalid:

  • expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.21.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual cherrypick of #3188

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pawanpinjarkar
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-62717, which is invalid:

  • expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.21.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pawanpinjarkar
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 3, 2025
@openshift-ci-robot
Copy link

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-62717, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-62680 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-62680 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (vkolodny@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 3, 2025
@rawagner
Copy link
Member

rawagner commented Oct 7, 2025

/retest

@andfasano
Copy link

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2025

@andfasano: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rawagner
Copy link
Member

rawagner commented Oct 7, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pawanpinjarkar, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2025
@pawanpinjarkar
Copy link
Contributor Author

/verified by @pawanpinjarkar

@openshift-ci-robot
Copy link

@pawanpinjarkar: This PR has been marked as verified by @pawanpinjarkar.

Details

In response to this:

/verified by @pawanpinjarkar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andfasano
Copy link

/label backport-risk-assessed

@rawagner
Copy link
Member

rawagner commented Oct 8, 2025

/label backport-risk-assessed

@openshift-ci
Copy link

openshift-ci bot commented Oct 8, 2025

@rawagner: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers]

Details

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pawanpinjarkar
Copy link
Contributor Author

Cc @zaneb

@andfasano
Copy link

@sdodson can you maybe help with the missing labels here? Thanks

@pawanpinjarkar
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2025
@pawanpinjarkar pawanpinjarkar reopened this Oct 9, 2025
@openshift-ci-robot
Copy link

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-62717. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

Manual cherrypick of #3188

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-62717, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-62680 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-62680 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (vkolodny@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual cherrypick of #3188

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pawanpinjarkar
Copy link
Contributor Author

/hold

@zaneb
Copy link
Contributor

zaneb commented Oct 9, 2025

/label backport-risk-assessed

Given the high risk here (i.e. of not being able to build a new 4,20 release image), I think it makes sense to hold off on this until the requirement for staff-eng-approved is dropped.

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 9, 2025
@andfasano
Copy link

Requires openshift-eng/ocp-build-data#7850

@pawanpinjarkar
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2025
@sdodson
Copy link

sdodson commented Oct 21, 2025

/label staff-eng-approved

@openshift-ci
Copy link

openshift-ci bot commented Oct 21, 2025

@sdodson: Can not set label staff-eng-approved: Must be member in one of these teams: [openshift-patch-managers openshift-staff-engineers openshift-sustaining-engineers]

Details

In response to this:

/label staff-eng-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zaneb
Copy link
Contributor

zaneb commented Oct 21, 2025

/tide refresh

@zaneb
Copy link
Contributor

zaneb commented Oct 21, 2025

/label staff-eng-approved

@openshift-ci openshift-ci bot added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Oct 21, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 0aa952b into openshift-assisted:release-4.20 Oct 21, 2025
4 checks passed
@openshift-ci-robot
Copy link

@pawanpinjarkar: Jira Issue Verification Checks: Jira Issue OCPBUGS-62717
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-62717 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Manual cherrypick of #3188

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). verified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants