AGENT-1260: Switch to rhel-9-base-nodejs-openshift base image#3124
Conversation
For nodejs builds switch image from nodejs-18-minimal.
|
@rwsu: This pull request references AGENT-1260 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
WalkthroughUpdated the UI build stage base image in apps/assisted-disconnected-ui/Containerfile.ocp and removed the microdnf installation of rsync and git. No other lines changed and no public/exported declarations were affected. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Hi @rwsu. Thanks for your PR. I'm waiting for a openshift-assisted member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
added
needs-ok-to-test
|
/cc @rawagner |
|
@rwsu: This pull request references AGENT-1260 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/assisted-disconnected-ui/Containerfile.ocp (1)
1-1: Optional: parameterize the OCP minor to avoid duplication and ease future bumps.You reference 4.19 in two FROMs (Node and Go). Consider a single ARG for the OCP minor to keep them in sync and simplify future upgrades. Also consider pinning to image digests for supply-chain stability.
Example:
Add at the top:
ARG OCP_MINOR=4.19Then:
FROM registry.ci.openshift.org/ocp/builder:rhel-9-base-nodejs-openshift-${OCP_MINOR} AS ui-build
...
FROM registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.23-openshift-${OCP_MINOR} as proxy-build
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
apps/assisted-disconnected-ui/Containerfile.ocp(1 hunks)
🔇 Additional comments (3)
apps/assisted-disconnected-ui/Containerfile.ocp (3)
1-1: LGTM on switching to the OCP NodeJS builder (pinned to 4.19).This change improves alignment with OCP builder images and removes the need for manual package installs. Tag pinning (vs latest) is appreciated.
1-1: Double-check target version alignment (4.19 vs. CI bot’s note about 4.20).CI noted the JIRA target version should be 4.20.0. If that’s a release targeting requirement (not just a ticket field), consider switching the base image(s) to the 4.20 stream. If 4.19 is intentional, ignore.
1-1: Manual verification required: ensure tooling in the new base imageThe check script failed because neither podman nor docker is installed locally. To prevent CI build failures, please install one of these runtimes and re‐run the following in your environment:
#!/usr/bin/env bash set -euo pipefail IMAGE="registry.ci.openshift.org/ocp/builder:rhel-9-base-nodejs-openshift-4.19" RUNTIME="$(command -v podman || command -v docker)" $RUNTIME run --rm --entrypoint /bin/sh "$IMAGE" -lc ' echo "node: $(node -v 2>/dev/null || echo missing)" echo "npm: $(npm -v 2>/dev/null || echo missing)" echo "git: $(git --version 2>/dev/null || echo missing)" echo "corepack: $(corepack --version 2>/dev/null || echo missing)" 'Verify the image reports versions (not “missing”) for:
- node
- npm
- git
- corepack
If any are missing, add
microdnf install -y <tool>back into the Containerfile.
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: celdrake, rwsu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 8071f75
into
openshift-assisted:master
3 participants
For nodejs builds switch image from nodejs-18-minimal.
Summary by CodeRabbit