Do not add staging-released tag for chatbot release#3105
Conversation
WalkthroughThe GitHub Actions workflow push-to-master.yaml updates a regex in the “Generate tags” step to exclude tags ending with -chatbot in addition to -cim when appending staging-released. No other steps or logic in the workflow are modified. Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant GH as GitHub Actions
participant Step as Generate tags step
Dev->>GH: Push tag
GH->>Step: Run tag-generation logic
alt tag ends with -cim or -chatbot
Step-->>GH: Do not append "staging-released"
else other tags
Step-->>GH: Append "staging-released"
end
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
openshift-ci
bot
added
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/push-to-master.yaml (1)
60-62: Consider covering pre-release variants (e.g., -chatbot-rc, -chatbot.1).If chatbot tags sometimes include extra suffixes, the current
-(cim|chatbot)$won’t match, andstaging-releasedwould be added. If that’s undesired, broaden the regex:- if [[ ! "${GITHUB_REF_NAME}" =~ -(cim|chatbot)$ ]]; then + if [[ ! "${GITHUB_REF_NAME}" =~ -(cim|chatbot)([-.].+)?$ ]]; thenPlease confirm how chatbot tags are formatted (exactly
-chatbotvs.-chatbot-*). If variants exist, the above change will keep them excluded as well. I can update the PR accordingly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/push-to-master.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: tests
- GitHub Check: translation-files
- GitHub Check: lint
- GitHub Check: format
- GitHub Check: unit-tests
- GitHub Check: circular-deps
🔇 Additional comments (1)
.github/workflows/push-to-master.yaml (1)
60-62: Change aligns with objective — '-chatbot' no longer gets 'staging-released'.The updated regex correctly prevents adding
staging-releasedfor tags ending with-chatbot. This matches the PR intent without altering other logic.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ammont82, rawagner The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
openshift-merge-bot
bot
merged commit 9d9bb8c
into
openshift-assisted:master
2 participants
Summary by CodeRabbit