Decouple release of chatbot from OCM/CIM#3079
Decouple release of chatbot from OCM/CIM#3079openshift-merge-bot[bot] merged 1 commit intoopenshift-assisted:masterfrom
Conversation
WalkthroughThe release workflow in Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant Release Script
GitHub Actions->>Release Script: Trigger on release tag/branch
Release Script->>Release Script: Check if tag ends with "-cim" or "-chatbot"
alt Tag ends with "-chatbot"
Release Script->>Release Script: Set LIBS to "chatbot"
else Tag ends with "-cim"
Release Script->>Release Script: Set LIBS to all public libs except "chatbot"
else Not a release tag
Release Script->>Release Script: Log not a chatbot release
end
Release Script->>GitHub Actions: Continue workflow with selected LIBS
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested labels
Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
openshift-ci
bot
added
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/release.yaml (1)
17-21: Nit: update log messages for clarityThe log headings (
OCM:,CIM:) pre-date the new chatbot option and can confuse operators.
Consider concise, neutral wording such as “Not a CIM or Chatbot release…”.
rawagner
force-pushed
the
decouple_chatbot_release
branch
from
95adc77 to
af52f01
Compare
openshift-ci
bot
added
size/M
rawagner
force-pushed
the
decouple_chatbot_release
branch
from
af52f01 to
224f9d8
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/RELEASE_WORKFLOW.md (1)
31-38: Tweak the branch / tag pattern to avoid a dangling hyphen when no suffix is used.With the current wording, an “OCM” (no-suffix) release strictly matching
releases/v1.2.3-would contain a trailing dash that does not exist in practice.
A tiny wording adjustment keeps the example accurate:-`releases/v<some-semver-string>-<optionally_a_suffix>` +`releases/v<some-semver-string>[ -<suffix> ]`Repeat the same tweak for the Tag and Title examples below.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/release.yaml(2 hunks)docs/RELEASE_WORKFLOW.md(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/release.yaml
🧰 Additional context used
🧠 Learnings (1)
docs/RELEASE_WORKFLOW.md (1)
Learnt from: celdrake
PR: #3051
File: libs/chatbot/lib/components/ChatBot/ChatBotWindow.tsx:196-222
Timestamp: 2025-07-18T12:35:50.945Z
Learning: In the assisted-installer-ui chatbot feedback implementation, the onFeedbackSubmit callback requires access to the messages array to retrieve both the bot response content and the associated user question for the API call, making it necessary to include messages in the useCallback dependency array rather than passing message content as props to avoid duplicating potentially long message data.
🪛 LanguageTool
docs/RELEASE_WORKFLOW.md
[grammar] ~29-~29: Ensure spelling is correct
Context: ... 1. Make sure you have been granted the maintaner role in the project settings. 2. Creat...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: tests
- GitHub Check: lint
🔇 Additional comments (2)
docs/RELEASE_WORKFLOW.md (2)
21-26: Good call-out of the three release “flavors”.Explicitly listing the
OCM,CIM, andChatbotvariants removes guess-work for maintainers and aligns the docs with the new automation.
47-47: Artifact list updated correctly.Adding
@openshift-assisted/chatbotreflects the new publish step—looks good.
celdrake
left a comment
celdrake
left a comment
There was a problem hiding this comment.
Looks good.
We can change the versioning for the Chatbot later if we want.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: celdrake, rawagner The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit a3be475
into
openshift-assisted:master
2 participants
Update release script to handle
-chatbotreleases.Chatbot package is included only in
-chatbotrelease, not in OCM or CIM.Summary by CodeRabbit