MGMT-20809: Add hosts menu is not fully seen on infraenv page

[jgyselov]

https://issues.redhat.com/browse/MGMT-20809

Before:

After:

Summary by CodeRabbit

• Bug Fixes
  • Improved dropdown positioning to prevent it from overflowing outside the viewport or container.

[coderabbitai]

Walkthrough

A property was added to the Dropdown component within the AddHostDropdown React component to configure its positioning behavior, specifically to prevent overflow outside the viewport or container. No other code, logic, or UI elements were changed.

Changes

File(s)	Change Summary
libs/ui-lib/lib/cim/components/InfraEnv/AddHostDropdown.tsx	Added popperProps={{ preventOverflow: true }} to Dropdown component.

Poem

In the dropdown’s gentle hop,
A popper keeps it in its spot—
No overflow, no bounding fright,
Just menus nestled snug and right.
A tiny tweak, a bounding cheer,
For hosts and rabbits, all is clear! 🐇

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

libs/ui-lib/lib/cim/components/InfraEnv/AddHostDropdown.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "@openshift-assisted/eslint-config" to extend from. Please check that the name of the config is correct.

The config "@openshift-assisted/eslint-config" was referenced from the config file in "/libs/ui-lib/.eslintrc.cjs".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[jgyselov]

/cherry-pick releases/v2.15-cim

[openshift-ci-robot]

@jgyselov: This pull request references MGMT-20809 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/MGMT-20809

Before:

After:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jgyselov: This pull request references MGMT-20809 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/MGMT-20809

Before:

After:

Summary by CodeRabbit

• Bug Fixes
• Improved dropdown positioning to prevent it from overflowing outside the viewport or container.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

libs/ui-lib/lib/cim/components/InfraEnv/AddHostDropdown.tsx (1)

78-78: Verify proper Popper modifier usage

PatternFly’s popperProps forwards options to PopperJS, which expects modifiers rather than a direct preventOverflow boolean. Confirm that the shorthand popperProps={{ preventOverflow: true }} is supported; if not, switch to a modifier-based API:

- popperProps={{ preventOverflow: true }}
+ popperProps={{
+   modifiers: [
+     { name: 'preventOverflow', options: { boundary: 'viewport' } },
+   ],
+ }}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e74106f and 2642c5d.

📒 Files selected for processing (1)

• libs/ui-lib/lib/cim/components/InfraEnv/AddHostDropdown.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: tests
• GitHub Check: circular-deps
• GitHub Check: translation-files
• GitHub Check: unit-tests
• GitHub Check: format
• GitHub Check: lint

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ammont82, jgyselov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ammont82,jgyselov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ammont82]

/lgtm

[openshift-cherrypick-robot]

@jgyselov: new pull request created: #2992

Details

In response to this:

/cherry-pick releases/v2.15-cim

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.