MGMT-20508: Not correct number of CPs on cluster details page when trying to cont…

[ElayAharoni]

https://issues.redhat.com/browse/MGMT-20508

fixed the issue, now shows the correct number of control planes in the UI and in the yaml and able to click the next button and proceed.

Summary by CodeRabbit

• Bug Fixes
  • Improved selection of the OpenShift version to better handle scenarios where a forced version is specified, ensuring accurate display of supported CPU architectures and high availability options.

[openshift-ci-robot]

@ElayAharoni: This pull request references MGMT-20508 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/MGMT-20508

fixed the issue, now shows the correct number of control planes in the UI and in the yaml and able to click the next button and proceed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

The logic for selecting the OpenShift version object in the cluster deployment details form was updated to consider both the user-selected version and a forced version. The dependencies for computing CPU architectures and high availability support were also updated to include the forced version.

Changes

File(s)	Change Summary
libs/ui-lib/lib/cim/components/ClusterDeployment/ClusterDeploymentDetailsForm.tsx	Updated OpenShift version selection logic to include forceOpenshiftVersion and adjusted dependencies.

Suggested labels

lgtm, approved, size/XS

Suggested reviewers

• jgyselov

Poem

A cluster hops, a version picked,
Now forced or chosen—logic clicked!
CPU lists and HA dreams,
React to changes, so it seems.
With every patch, the code grows strong,
🐇 Cheers to progress—hop along!

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

libs/ui-lib/lib/cim/components/ClusterDeployment/ClusterDeploymentDetailsForm.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "@openshift-assisted/eslint-config" to extend from. Please check that the name of the config is correct.

The config "@openshift-assisted/eslint-config" was referenced from the config file in "/libs/ui-lib/.eslintrc.cjs".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2675219 and db0e88b.

📒 Files selected for processing (1)

• libs/ui-lib/lib/cim/components/ClusterDeployment/ClusterDeploymentDetailsForm.tsx (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

libs/ui-lib/lib/cim/components/ClusterDeployment/ClusterDeploymentDetailsForm.tsx (1)

libs/ui-lib/lib/common/types/cpuArchitecture.ts (1)

• SupportedCpuArchitecture (40-43)

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: tests
• GitHub Check: translation-files
• GitHub Check: unit-tests
• GitHub Check: lint
• GitHub Check: format
• GitHub Check: circular-deps

🔇 Additional comments (2)

libs/ui-lib/lib/cim/components/ClusterDeployment/ClusterDeploymentDetailsForm.tsx (2)

115-117: LGTM! Proper fallback logic for version selection.

The updated logic correctly handles both user-selected and forced OpenShift versions. The OR condition appropriately prioritizes the user-selected version (values.openshiftVersion) while falling back to the forced version (forceOpenshiftVersion) when needed.

---

125-125: Correct dependency array update.

Adding forceOpenshiftVersion to the dependency array is necessary since it's now used within the useMemo hook. This ensures the memoized values are recalculated when the forced version changes.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[openshift-ci-robot]

@ElayAharoni: This pull request references MGMT-20508 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/MGMT-20508

fixed the issue, now shows the correct number of control planes in the UI and in the yaml and able to click the next button and proceed.

Summary by CodeRabbit

• Bug Fixes
• Improved selection of the OpenShift version to better handle scenarios where a forced version is specified, ensuring accurate display of supported CPU architectures and high availability options.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElayAharoni, jgyselov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jgyselov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jgyselov]

/cherry-pick releases/v2.15-cim

[openshift-cherrypick-robot]

@jgyselov: once the present PR merges, I will cherry-pick it on top of releases/v2.15-cim in a new PR and assign it to you.

Details

In response to this:

/cherry-pick releases/v2.15-cim

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@jgyselov: new pull request created: #2967

Details

In response to this:

/cherry-pick releases/v2.15-cim

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jgyselov]

/cherry-pick releases/v2.14-cim

[openshift-cherrypick-robot]

@jgyselov: new pull request created: #2970

Details

In response to this:

/cherry-pick releases/v2.14-cim

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.