MGMT-20659: Select virtualization bundle and LVM operator when user came from Assisted Migration wizard#2953
Conversation
…isted Migration wizard
openshift-ci-robot
added
the
jira/valid-reference
|
@ammont82: This pull request references MGMT-20659 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThis change removes provisional assisted migration logic from the codebase. It deletes the creation and injection of custom manifests for assisted migration, eliminates related YAML constants, and updates the cluster creation flow to select a virtualization bundle instead. The affected logic spans cluster configuration, cluster creation, constants, and service layers. Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetails.tsxOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the config "@openshift-assisted/eslint-config" to extend from. Please check that the name of the config is correct. The config "@openshift-assisted/eslint-config" was referenced from the config file in "/libs/ui-lib/.eslintrc.cjs". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team. Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
openshift-ci
bot
added
approved
|
@ammont82: This pull request references MGMT-20659 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetails.tsx (2)
78-81: Fix comment formatting and consider preserving existing operatorsThe comment has a grammatical error. Additionally, the current implementation might override any existing
olmOperatorsin theparamsobject rather than adding to them.- //For Assisted Migration we need to LVMs operator + // For Assisted Migration we need to add the LVM operator if (isAssistedMigration) { - params.olmOperators = [{ name: 'lvm' }]; + params.olmOperators = params.olmOperators ? [...params.olmOperators, { name: 'lvm' }] : [{ name: 'lvm' }]; }
85-88: Fix comment formattingThe comment should follow consistent formatting standards with space after
//.- //For Assisted Migration we need to enable virtualization bundle + // For Assisted Migration we need to enable virtualization bundle if (isAssistedMigration) { await UISettingService.update(cluster.id, { bundlesSelected: ['virtualization'] }); }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (4)
libs/ui-lib/lib/ocm/components/clusterConfiguration/CustomManifestCheckbox.tsx(0 hunks)libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetails.tsx(1 hunks)libs/ui-lib/lib/ocm/config/constants.ts(0 hunks)libs/ui-lib/lib/ocm/services/ClustersService.ts(0 hunks)
💤 Files with no reviewable changes (3)
- libs/ui-lib/lib/ocm/components/clusterConfiguration/CustomManifestCheckbox.tsx
- libs/ui-lib/lib/ocm/config/constants.ts
- libs/ui-lib/lib/ocm/services/ClustersService.ts
🧰 Additional context used
🧬 Code Graph Analysis (1)
libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetails.tsx (1)
libs/ui-lib/lib/ocm/components/clusterWizard/wizardTransition.ts (1)
ClusterWizardFlowStateNew(48-48)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: translation-files
- GitHub Check: tests
- GitHub Check: unit-tests
- GitHub Check: lint
- GitHub Check: format
- GitHub Check: circular-deps
🔇 Additional comments (1)
libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetails.tsx (1)
72-99:Details
✅ Verification successful
Verify parameter propagation to ClustersService.create()
The code correctly implements the requirements by adding LVM operator and enabling the virtualization bundle. However, I'd like to verify that the
isAssistedMigrationparameter is correctly used in theClustersService.create()method.
🏁 Script executed:
#!/bin/bash # Search for ClustersService.create implementation to verify how isAssistedMigration is used rg -A 10 "create\s*\(\s*params.*isAssistedMigration" --type tsLength of output: 2481
ClustersService.create correctly handles isAssistedMigration
Confirmed that whenisAssistedMigrationis true,ClustersService.createadds theAI_ASSISTED_MIGRATION_TAGtoparams.tagsbefore calling the API. No further changes needed.
|
/cherry-pick releases/v2.41 |
|
@ammont82: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ammont82, celdrake The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 9db44ae
into
openshift-assisted:master
|
@ammont82: new pull request created: #2954 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…isted Migration wizard (openshift-assisted#2953)
4 participants
Related with https://issues.redhat.com/browse/MGMT-20659
When we go to cluster creating wizard with the parameter "source=assisted_migration" (openshift/assisted-installer/clusters/~new?source=assisted_migration) we select the Virtualization bundle by default and the LVMS operator.
Summary by CodeRabbit
Bug Fixes
Chores