MGMT-20616: Refactor Header component to use not deprecated components of patternfly

[ElayAharoni]

https://issues.redhat.com/browse/MGMT-20616

used Patternfly's Masthead components instead of PageHeader

Summary by CodeRabbit

• Refactor
  • Updated the header layout to use newer design components for improved consistency and appearance.
  • The logo is now displayed without a direct link to the homepage.
  • Feedback and about buttons remain accessible in the header with an updated layout.

[coderabbitai]

Walkthrough

The Header component was refactored to replace deprecated PatternFly components with updated equivalents. The layout now uses Masthead, MastheadBrand, and MastheadMain for structure, with the logo and action buttons reorganized accordingly. No changes were made to the exported function's signature.

Changes

File(s)	Change Summary
apps/assisted-ui/src/components/Header.tsx	Refactored to use Masthead, MastheadBrand, and MastheadMain instead of deprecated components; reorganized logo and buttons; removed logo link.

Poem

In the meadow of code, the header hops anew,
Old tools retired, as fresh ones debut.
Masthead and Brand now lead the way,
With buttons and logos in bright array.
A modern look, a tidy nest—
The rabbit approves this coding quest! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/assisted-ui/src/components/Header.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "@openshift-assisted/eslint-config" to extend from. Please check that the name of the config is correct.

The config "@openshift-assisted/eslint-config" was referenced from the config file in "/apps/assisted-ui/.eslintrc.cjs".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

apps/assisted-ui/src/components/Header.tsx (1)

7-7: Avoid inline styles; use PatternFly utility classes.

Relying on inline style makes overrides harder to manage. You can leverage PF utility classes for consistent theming:

- <Masthead style={{ display: 'flex', justifyContent: 'space-between' }}>
+ <Masthead className="pf-u-display-flex pf-u-justify-content-space-between">

This also enables easier customization via your global CSS or theming tokens.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4ad4812 and ee3f1e7.

📒 Files selected for processing (1)

• apps/assisted-ui/src/components/Header.tsx (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

apps/assisted-ui/src/components/Header.tsx (2)

apps/assisted-ui/src/components/FeedbackButton.tsx (1)

• FeedbackButton (6-14)

apps/assisted-ui/src/components/AboutButton.tsx (1)

• AboutButton (6-18)

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: circular-deps
• GitHub Check: unit-tests
• GitHub Check: translation-files
• GitHub Check: tests
• GitHub Check: format
• GitHub Check: lint

🔇 Additional comments (3)

apps/assisted-ui/src/components/Header.tsx (3)

2-2: Removed deprecated imports; approved change.

The switch from the deprecated PageHeader and PageHeaderTools imports to the current Masthead components aligns well with PatternFly’s migration guide and improves maintainability.

---

8-16: Verify logo link behavior and asset resolution.

• The previous logoProps={{ href: '/' }} was removed, so the brand logo is no longer clickable. Please confirm if it should still navigate to the home/dashboard route. If so, wrap <Brand> in a React Router <Link> or re-add an href on the containing element.
• Referencing "/logo.svg" directly assumes a root‐mounted public path. In non-root deployments, this can break. Consider importing the SVG and using it as a module:

-import { Brand } from '@patternfly/react-core';
+import { Brand } from '@patternfly/react-core';
+import logo from 'assets/logo.svg';

…
- <Brand src="/logo.svg" alt="…">
+ <Brand src={logo} alt="Assisted Installer logo">

---

17-20: Confirm correct container for action buttons.

In PatternFly’s masthead pattern, header control buttons (feedback, about) are commonly placed within <MastheadTools> (or nested under <MastheadContent>). You’re using <MastheadMain>—please verify against the PF docs that this component is semantically appropriate. If not, replace with the recommended container:

<MastheadContent>
  <MastheadTools>
    <FeedbackButton />
    <AboutButton />
  </MastheadTools>
</MastheadContent>

[openshift-ci-robot]

@ElayAharoni: This pull request references MGMT-20616 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/MGMT-20616

used Patternfly's Masthead components instead of PageHeader

Summary by CodeRabbit

• Refactor
• Updated the header layout to use newer design components for improved consistency and appearance.
• The logo is now displayed without a direct link to the homepage.
• Feedback and about buttons remain accessible in the header with an updated layout.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jgyselov]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElayAharoni, jgyselov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jgyselov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment