Update msg in ABI finalizer page.#2937
Update msg in ABI finalizer page.#2937openshift-merge-bot[bot] merged 1 commit intoopenshift-assisted:masterfrom
Conversation
WalkthroughThis change updates the user-facing message in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
apps/assisted-disconnected-ui/src/components/SingleClusterFinalizerPage.tsxOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the config "@openshift-assisted/eslint-config" to extend from. Please check that the name of the config is correct. The config "@openshift-assisted/eslint-config" was referenced from the config file in "/apps/assisted-disconnected-ui/.eslintrc.cjs". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team. ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/assisted-disconnected-ui/src/components/SingleClusterFinalizerPage.tsx (1)
38-38: Consider using semantic list markup for bullet points
Instead of a literal asterisk (*) in the text, you could leverage PatternFly’s<List>and<ListItem>components inside<EmptyStateBody>for better HTML semantics and styling consistency.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/assisted-disconnected-ui/src/components/SingleClusterFinalizerPage.tsx(1 hunks)libs/locales/lib/en/translation.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: tests
- GitHub Check: translation-files
- GitHub Check: unit-tests
- GitHub Check: circular-deps
- GitHub Check: format
- GitHub Check: lint
🔇 Additional comments (2)
libs/locales/lib/en/translation.json (1)
30-30: Add translation for finalizer page warning
A new translation key and value have been introduced for the concise browser-close warning. This maps to the message shown in the finalizer page component.apps/assisted-disconnected-ui/src/components/SingleClusterFinalizerPage.tsx (1)
38-38: Add concise finalizer warning message
The new line references the matching translation key to warn users they cannot return once the window is closed. This aligns with the updated translation and keeps the UI text consistent.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ElayAharoni, rawagner The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4bc6a50
into
openshift-assisted:master
Summary by CodeRabbit