Skip to content

Update msg in ABI finalizer page.#2937

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-assisted:masterfrom
rawagner:abi_finalizer_page
Apr 28, 2025
Merged

Update msg in ABI finalizer page.#2937
openshift-merge-bot[bot] merged 1 commit intoopenshift-assisted:masterfrom
rawagner:abi_finalizer_page

Conversation

@rawagner
Copy link
Copy Markdown
Member

@rawagner rawagner commented Apr 28, 2025

Summary by CodeRabbit

  • Style
    • Updated the message shown to users during cluster finalization for improved clarity and brevity.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 28, 2025

Walkthrough

This change updates the user-facing message in the SingleClusterFinalizerPage component. The previous message, which provided instructions about finding the webconsole URL in the credentials file and indicated that cluster installation was still in progress, has been replaced with a shorter statement warning users that closing the browser window will prevent them from returning. The update affects both the component's source code and its corresponding English translation string. No other functionality or exported entities were modified.

Changes

File(s) Change Summary
apps/assisted-disconnected-ui/src/components/SingleClusterFinalizerPage.tsx Updated the message in the EmptyStateBody to a shorter warning about not being able to return if the browser window is closed.
libs/locales/lib/en/translation.json Modified the translation string for the warning message to match the new, shorter text.

Possibly related PRs

Suggested labels

lgtm, approved, size/L

Suggested reviewers

  • celdrake
  • ElayAharoni

Poem

A message once long, now short and sweet,
Warns users not to admit defeat.
"Close this tab? You can't return!"
Simple words, so all can learn.
With every tweak, our UI grows neat—
🐇 Hopping forward, light on its feet!

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/assisted-disconnected-ui/src/components/SingleClusterFinalizerPage.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "@openshift-assisted/eslint-config" to extend from. Please check that the name of the config is correct.

The config "@openshift-assisted/eslint-config" was referenced from the config file in "/apps/assisted-disconnected-ui/.eslintrc.cjs".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@openshift-ci openshift-ci bot requested review from ElayAharoni and jgyselov April 28, 2025 07:05
@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2025
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apps/assisted-disconnected-ui/src/components/SingleClusterFinalizerPage.tsx (1)

38-38: Consider using semantic list markup for bullet points
Instead of a literal asterisk (*) in the text, you could leverage PatternFly’s <List> and <ListItem> components inside <EmptyStateBody> for better HTML semantics and styling consistency.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d1498c and 97b8905.

📒 Files selected for processing (2)
  • apps/assisted-disconnected-ui/src/components/SingleClusterFinalizerPage.tsx (1 hunks)
  • libs/locales/lib/en/translation.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: tests
  • GitHub Check: translation-files
  • GitHub Check: unit-tests
  • GitHub Check: circular-deps
  • GitHub Check: format
  • GitHub Check: lint
🔇 Additional comments (2)
libs/locales/lib/en/translation.json (1)

30-30: Add translation for finalizer page warning
A new translation key and value have been introduced for the concise browser-close warning. This maps to the message shown in the finalizer page component.

apps/assisted-disconnected-ui/src/components/SingleClusterFinalizerPage.tsx (1)

38-38: Add concise finalizer warning message
The new line references the matching translation key to warn users they cannot return once the window is closed. This aligns with the updated translation and keeps the UI text consistent.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElayAharoni, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4bc6a50 into openshift-assisted:master Apr 28, 2025
11 checks passed
ammont82 pushed a commit to ammont82/assisted-installer-ui that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants