ABI: Do not show kubeconfig deletion info

[rawagner]

Summary by CodeRabbit

• New Features

  • The kubeconfig download alert is now shown only when a specific feature flag is disabled, in addition to existing conditions.

• Refactor

  • Improved conditional rendering for alerts to enhance clarity and maintainability.

[coderabbitai]

Walkthrough

The code refactors the conditional rendering logic within the ClusterDetailStatusMessages component. The RenderIf utility was removed and replaced by direct conditional rendering using logical operators. A new feature flag, accessed via the useFeature hook, is now used to determine whether the kubeconfig download alert should be displayed. The logic for rendering alerts has been updated to use inline conditions, but the component's interface and other alert logic remain unchanged.

Changes

File(s)	Change Summary
libs/ui-lib/lib/ocm/components/clusterDetail/ClusterDetailStatusMessages.tsx	Replaced RenderIf with inline conditional rendering; introduced useFeature hook for feature flag checks; updated alert rendering logic.

Suggested labels

lgtm, approved, size/L

Suggested reviewers

• celdrake
• jgyselov

Poem

A bunny hops through lines anew,
Swapping wrappers for logic true.
Feature flags now lead the way,
Alerts appear, then hop away.
With simple checks and tidy code,
The cluster’s status clearly showed!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

libs/ui-lib/lib/ocm/components/clusterDetail/ClusterDetailStatusMessages.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "@openshift-assisted/eslint-config" to extend from. Please check that the name of the config is correct.

The config "@openshift-assisted/eslint-config" was referenced from the config file in "/libs/ui-lib/.eslintrc.cjs".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between afade65 and 0736f6b.

📒 Files selected for processing (1)

• libs/ui-lib/lib/ocm/components/clusterDetail/ClusterDetailStatusMessages.tsx (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: translation-files
• GitHub Check: circular-deps
• GitHub Check: lint
• GitHub Check: unit-tests
• GitHub Check: format
• GitHub Check: tests

🔇 Additional comments (4)

libs/ui-lib/lib/ocm/components/clusterDetail/ClusterDetailStatusMessages.tsx (4)

18-18: LGTM: Added feature hook for conditional rendering.

Adding the useFeature hook is appropriate for implementing feature-flag-based rendering.

---

29-29: LGTM: Good feature flag implementation.

The variable name is descriptive and clearly indicates the purpose of the flag check.

---

47-60: LGTM: Well-implemented conditional rendering.

The refactoring from a RenderIf component to direct conditional rendering with logical operators improves readability while maintaining the same conditional logic. The addition of the !isSingleClusterFeatureEnabled check properly implements the PR objective of hiding kubeconfig deletion information when the feature flag is enabled.

---

61-78: LGTM: Simplified rendering pattern.

The refactoring to use direct conditional rendering with the logical && operator instead of a wrapper component improves code clarity while maintaining the same behavior.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElayAharoni, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [rawagner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment