MGMT-20351: selecting CNV - not able to deselect it using UI#2906
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@ElayAharoni: This pull request references MGMT-20351 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThe function Changes
Sequence Diagram(s)sequenceDiagram
participant Caller as Caller
participant FS as getCnvDisabledWithMtvReason
Caller->>+FS: call(operatorValues)
Note right of FS: Check if !useMigrationToolkitforVirtualization
FS-->>-Caller: Return CNV disable reason message
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
libs/ui-lib/lib/ocm/components/featureSupportLevels/featureStateUtils.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the config "@openshift-assisted/eslint-config" to extend from. Please check that the name of the config is correct. The config "@openshift-assisted/eslint-config" was referenced from the config file in "/libs/ui-lib/.eslintrc.cjs". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (6)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
openshift-ci
bot
added
the
size/XS
|
@ElayAharoni: This pull request references MGMT-20351 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ElayAharoni
force-pushed
the
selecting-CNV--not-able-to-deselect-it-using-UI
branch
from
6fe538f to
2bbd16c
Compare
|
@ElayAharoni: This pull request references MGMT-20351 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
libs/ui-lib-tests/cypress/integration/ui-behaviour/cluster-updates.cy.ts(1 hunks)libs/ui-lib-tests/cypress/views/operatorsPage.ts(1 hunks)libs/ui-lib/lib/ocm/components/featureSupportLevels/featureStateUtils.ts(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- libs/ui-lib/lib/ocm/components/featureSupportLevels/featureStateUtils.ts
🧰 Additional context used
🧬 Code Graph Analysis (1)
libs/ui-lib-tests/cypress/integration/ui-behaviour/cluster-updates.cy.ts (1)
libs/ui-lib-tests/cypress/views/operatorsPage.ts (1)
operatorsPage(1-11)
🪛 Biome (1.9.4)
libs/ui-lib-tests/cypress/views/operatorsPage.ts
[error] 5-5: Did you mean to use a :? An = can only follow a property name when the containing object literal is part of a destructuring pattern.
(parse)
🔇 Additional comments (1)
libs/ui-lib-tests/cypress/integration/ui-behaviour/cluster-updates.cy.ts (1)
40-40: LGTM: Test update aligns with CNV dependency on MTVThe test has been correctly updated to click the Migration Toolkit for Virtualization checkbox before attempting to enable OpenShift Virtualization, which aligns with the PR objective where "CNV operator is now disabled by default until the MTV operator is selected."
Signed-off-by: Elay Aharoni <elayaha@gmail.com>
ElayAharoni
force-pushed
the
selecting-CNV--not-able-to-deselect-it-using-UI
branch
from
2bbd16c to
09b2154
Compare
|
@ElayAharoni: This pull request references MGMT-20351 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ammont82, ElayAharoni The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 4f46665
into
openshift-assisted:master
…ssisted#2906)" This reverts commit 4f46665.
|
/cherry-pick releases/v2.39 |
|
@ammont82: new pull request created: #2914 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…2906) Signed-off-by: Elay Aharoni <elayaha@gmail.com>
…anges (openshift-assisted#2909) * Revert "selecting CNV - not able to deselect it using UI (openshift-assisted#2906)" This reverts commit 4f46665. * Selecting CNV - not able to deselect it using UI
4 participants
https://issues.redhat.com/browse/MGMT-20351
after the change the CNV operator is disabled by default until we select the MTV operator because right now the CNV operator can be selected only when selecting the MTV as well.
and then it will be automatically checked but if user wants it can remove the CNV operator and remain only with MTV.
https://www.loom.com/share/3f15f5622457465da194b51c56f3d3d9?sid=1fb93a91-fb97-4db8-9408-1239766b9b7e
Summary by CodeRabbit
Refactor
New Features
Tests