Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

Conversation

@ksubrmnn
Copy link
Contributor

@ksubrmnn ksubrmnn commented Jun 18, 2021

Description:
Cherry-picks 94fc23d and 1a7d0b5 for v0.9.1,
required to address #3509 with v0.9.

Affected area:

Functional Area
New Functionality [ ]
Documentation [ ]
Install [X]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Ingress [ ]
Egress [ ]
Networking [ ]
Observability [ ]
SMI Policy [ ]
Sidecar Injection [ ]
Security [ ]
Upgrade [ ]
Tests [ ]
CI System [ ]
Demo [X]
Performance [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?
    • Did you notify the maintainers and provide attribution?
      No
  2. Is this a breaking change?
    No

ksubrmnn and others added 2 commits June 18, 2021 13:03
Ensure that cleanup-hook is not scheduled on a Windows node

Signed-off-by: Sotiris Nanopoulos <[email protected]>
@ksubrmnn ksubrmnn requested a review from a team as a code owner June 18, 2021 20:11
@codecov-commenter
Copy link

Codecov Report

Merging #3625 (bdd664c) into release-v0.9 (96498ba) will increase coverage by 0.77%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           release-v0.9    #3625      +/-   ##
================================================
+ Coverage         65.82%   66.59%   +0.77%     
================================================
  Files               169      169              
  Lines              7886     7904      +18     
================================================
+ Hits               5191     5264      +73     
+ Misses             2664     2609      -55     
  Partials             31       31              
Flag Coverage Δ
unittests 66.59% <ø> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/injector/webhook.go 79.05% <0.00%> (ø)
pkg/injector/iptables.go 100.00% <0.00%> (ø)
pkg/configurator/mock_client_generated.go 0.00% <0.00%> (ø)
pkg/injector/patch.go 77.19% <0.00%> (+0.40%) ⬆️
pkg/configurator/methods.go 69.01% <0.00%> (+0.44%) ⬆️
pkg/ingress/client.go 77.08% <0.00%> (+67.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96498ba...bdd664c. Read the comment docs.

@ksubrmnn ksubrmnn merged commit 09cdbc2 into openservicemesh:release-v0.9 Jun 18, 2021
@ksubrmnn ksubrmnn deleted the backport branch June 18, 2021 22:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants