This repository was archived by the owner on Jul 11, 2023. It is now read-only.
Backport inbound port exclusion and ingress ignore features #3623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to outbound port exclusions (global and pod scoped), this change adds support to exclude specified ports from inbound sidecar redirection. This is required in certain scenarios when traffic destined to certain ports should not be proxied to the sidecar (ex. ports that terminate TLS connections in the app). Required for openservicemesh#3582 Signed-off-by: Shashank Ram <[email protected]>
As a part of openservicemesh#3582, specific ingress resources need to be ignored. This change adds support for this using the existing `openservicemesh.io/ignore` label. Also addresses an unnecessary type export and makes unusued variable usage explicit. Signed-off-by: Shashank Ram <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release-v0.9 #3623 +/- ##
================================================
+ Coverage 65.82% 66.57% +0.74%
================================================
Files 169 169
Lines 7886 7904 +18
================================================
+ Hits 5191 5262 +71
+ Misses 2664 2611 -53
Partials 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
shashankram
changed the title
snehachhabria
approved these changes
Jun 18, 2021
allenlsy
approved these changes
Jun 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Cherry-picks 6664c75 and 9c7a2d9 for v0.9.1,
required to address #3582 with v0.9.
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
no