fix(e2e): Add default meshconfig #3565
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3565 +/- ##
==========================================
+ Coverage 66.12% 66.13% +0.01%
==========================================
Files 174 174
Lines 8309 8309
==========================================
+ Hits 5494 5495 +1
+ Misses 2784 2783 -1
Partials 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nshankar13
changed the title
| } | ||
| } | ||
|
|
||
| func (c *meshConfigs) GetDefaultConfig(resourceVersion string) (defaultConfig *v1alpha1.MeshConfig) { |
There was a problem hiding this comment.
Let's please create this in the common.go of the e2e, since it will be used only for the e2e tests and has hard coded values
There was a problem hiding this comment.
+1
This should not be updating the API.
There was a problem hiding this comment.
@shashankram @snehachhabria instead of creating a new meshconfig object, I will just override the fields I need to in the existing meshconfig. Otherwise, I am seeing that the envoy / init images that initially point to another registry (ex MCR) are being overridden and pointing to the osm dockerhub images instead every time the default is applied. Also, we don't necessarily want to hardcode values like Traffic.EnablePermissiveTrafficPolicyMode in the tests,
nshankar13
force-pushed
the
default_meshconfig_e2e
branch
from
b659fb4 to
6c5e7e0
Compare
nshankar13
force-pushed
the
default_meshconfig_e2e
branch
from
6c5e7e0 to
f5df16c
Compare
Signed-off-by: nshankar13 <[email protected]>
nshankar13
force-pushed
the
default_meshconfig_e2e
branch
from
f5df16c to
e13f4c7
Compare
|
@mergify backport release-v0.9 |
|
Command
Hey, I reacted but my real name is @Mergifyio |
…/pr-3565 fix(e2e): Add default meshconfig (backport #3565)
5 participants
Signed-off-by: nshankar13 [email protected]
Description: Add default meshconfig, and update the meshconfig with default for the noInstall option in e2e tests.
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
Is this a breaking change?