This repository was archived by the owner on Jul 11, 2023. It is now read-only.
fix(crds/meshconfig): remove envoy image pattern #3524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaellio
approved these changes
Jun 7, 2021
allenlsy
approved these changes
Jun 7, 2021
Contributor
allenlsy
left a comment
allenlsy
left a comment
There was a problem hiding this comment.
nit: can you update the PR description to clarify why we make this change?
nshankar13
force-pushed
the
remove_envoy_pattern
branch
from
1d6bbaa to
89cf8f0
Compare
Signed-off-by: nshankar13 <[email protected]>
nshankar13
force-pushed
the
remove_envoy_pattern
branch
from
89cf8f0 to
56d9248
Compare
Contributor
Author
|
@Mergifyio backport release-v0.9 |
Contributor
|
Command
|
Contributor
Author
|
@Mergifyio backport release-v0.9 |
Contributor
|
Command
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nshankar13 [email protected]
Description: Remove envoy pattern in meshconfig to allow user to point to envoy image in any registry, not just the osm dockerhub image.
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
Is this a breaking change?