Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

Conversation

@ksubrmnn
Copy link
Contributor

@ksubrmnn ksubrmnn commented Jun 5, 2021

Signed-off-by: Kalya Subramanian [email protected]

Description:
Related to #3097

Skip FluentBit on OpenShift as OpenShift needs additional resources in order for it to work.

Affected area:

Functional Area
New Functionality [ ]
Documentation [ ]
Install [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Ingress [ ]
Egress [ ]
Networking [ ]
Observability [ ]
SMI Policy [ ]
Sidecar Injection [ ]
Security [ ]
Upgrade [ ]
Tests [X]
CI System [ ]
Demo [ ]
Performance [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?
    • Did you notify the maintainers and provide attribution?
      No
  2. Is this a breaking change?
    No

@ksubrmnn ksubrmnn requested a review from a team as a code owner June 5, 2021 00:07
@codecov-commenter
Copy link

Codecov Report

Merging #3518 (ba31134) into main (722614f) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3518      +/-   ##
==========================================
- Coverage   66.33%   66.27%   -0.06%     
==========================================
  Files         169      169              
  Lines        8067     8081      +14     
==========================================
+ Hits         5351     5356       +5     
- Misses       2686     2695       +9     
  Partials       30       30              
Flag Coverage Δ
unittests 66.27% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/catalog/catalog.go 92.85% <0.00%> (-7.15%) ⬇️
cmd/cli/install.go 70.79% <0.00%> (-0.76%) ⬇️
pkg/envoy/lds/response.go 64.15% <0.00%> (-0.56%) ⬇️
pkg/configurator/methods.go 68.11% <0.00%> (-0.46%) ⬇️
pkg/catalog/fake.go 37.39% <0.00%> (-0.33%) ⬇️
pkg/catalog/mock_catalog_generated.go 0.00% <0.00%> (ø)
pkg/configurator/mock_client_generated.go 0.00% <0.00%> (ø)
pkg/kubernetes/mock_controller_generated.go 0.00% <0.00%> (ø)
pkg/kubernetes/client.go 91.42% <0.00%> (+0.38%) ⬆️
pkg/envoy/cds/response.go 89.58% <0.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 722614f...ba31134. Read the comment docs.

@ksubrmnn ksubrmnn merged commit 536feb2 into openservicemesh:main Jun 7, 2021
@ksubrmnn ksubrmnn deleted the fluentbit_e2e branch June 7, 2021 16:58
shalier pushed a commit to shalier/osm that referenced this pull request Jun 30, 2021
@ksubrmnn ksubrmnn linked an issue Jul 20, 2021 that may be closed by this pull request
@nshankar13
Copy link
Contributor

@Mergifyio backport release-v0.9

mergify bot pushed a commit that referenced this pull request Jul 27, 2021
Signed-off-by: Kalya Subramanian <[email protected]>
(cherry picked from commit 536feb2)
@mergify
Copy link
Contributor

mergify bot commented Jul 27, 2021

Command backport release-v0.9: success

Backports have been created

nshankar13 pushed a commit that referenced this pull request Jul 27, 2021
Signed-off-by: Kalya Subramanian <[email protected]>
(cherry picked from commit 536feb2)
nshankar13 added a commit that referenced this pull request Jul 27, 2021
…/pr-3518

test(e2e): Skip FluentBit tests on OpenShift (backport #3518)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configure e2es to run on OpenShift

5 participants