Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Alias go-control-plane imports in xds.go #124

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

draychev
Copy link
Contributor

@draychev draychev commented Feb 6, 2020

Following the advice here: envoyproxy/go-control-plane#226 (comment)

Copy link
Member

@shashankram shashankram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -3,9 +3,9 @@ package lds
import (
"github.com/deislabs/smc/pkg/envoy"
xds "github.com/envoyproxy/go-control-plane/envoy/api/v2"
"github.com/envoyproxy/go-control-plane/envoy/api/v2/route"
route "github.com/envoyproxy/go-control-plane/envoy/api/v2/route"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call this envoyRoute

envoy_hcm "github.com/envoyproxy/go-control-plane/envoy/config/filter/network/http_connection_manager/v2"
"github.com/envoyproxy/go-control-plane/pkg/wellknown"
wellknown "github.com/envoyproxy/go-control-plane/pkg/wellknown"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call this envoyWellKnown

@draychev draychev merged commit 3f7d7a8 into master Feb 6, 2020
@draychev draychev deleted the draychev/alias-xds-imports branch February 6, 2020 18:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants