This repository was archived by the owner on Aug 8, 2023. It is now read-only.
manual_demo: fix HTTP route policy#110
Merged
shashankram merged 1 commit intoopenservicemesh:mainfrom Jun 2, 2021
shashankram:fix-demo
Merged
manual_demo: fix HTTP route policy#110shashankram merged 1 commit intoopenservicemesh:mainfrom shashankram:fix-demo
shashankram merged 1 commit intoopenservicemesh:mainfrom
shashankram:fix-demo
Conversation
The existing demo is broken because of incorrect host header matching specified which prevents bookbuyer from accessing the bookstore service. The host header in the HTTP request includes the port, but the spec was missing this. Since the host header feature is not complete (see openservicemesh/osm#2369) and this is unnecessary for this demo, this change removes it. The demo works as expected with SMI policies with this fix. Resolves openservicemesh/osm#3491 Signed-off-by: Shashank Ram <shashr2204@gmail.com>
|
✔️ Deploy Preview for osm-docs ready! 🔨 Explore the source changes: 51b2223 🔍 Inspect the deploy log: https://app.netlify.com/sites/osm-docs/deploys/60b7fa9a0308f700072c4b1e 😎 Browse the preview: https://deploy-preview-110--osm-docs.netlify.app |
snehachhabria
approved these changes
Jun 2, 2021
bridgetkromhout
approved these changes
Jun 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing demo is broken because of incorrect
host header matching specified which prevents
bookbuyer from accessing the bookstore service.
The host header in the HTTP request includes
the port, but the spec was missing this. Since
the host header feature is not complete (see
openservicemesh/osm#2369) and this is unnecessary
for this demo, this change removes it.
The demo works as expected with SMI policies
with this fix.
Resolves openservicemesh/osm#3491
Signed-off-by: Shashank Ram shashr2204@gmail.com