Skip to content

Fix manual CI workflow and add name option. #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yury-Fridlyand merged 1 commit into from
Oct 27, 2022
Merged

Fix manual CI workflow and add name option. #904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/sql-test-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@ name: SQL Plugin Tests

on:
workflow_dispatch:
inputs:
name:
Copy link
Collaborator

@acarbonetto acarbonetto Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a description, maybe with example? <branch name> @ <commit sha>

Copy link
Collaborator

@acarbonetto acarbonetto Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we call this branch_commit or similar?

Copy link
Collaborator Author

@Yury-Fridlyand Yury-Fridlyand Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a custom run name which could be specified to override the default value. Default is <branch name> @ <commit sha>

required: false
type: string

run-name:
${{ inputs.name == '' && format('{0} @ {1}', github.ref_name, github.sha) || inputs.name }}

jobs:
build:
Expand Down Expand Up @@ -64,10 +71,10 @@ jobs:

- name: Verify test results
run: |
if [[ -e failures.log ]]
if [[ -e report.log ]]
then
echo "## FAILED TESTS :facepalm::warning::bangbang:" >> $GITHUB_STEP_SUMMARY
cat failures.log >> $GITHUB_STEP_SUMMARY
cat report.log >> $GITHUB_STEP_SUMMARY
exit 1
fi

Expand Down