Trigger build on pull request synchronize action.

[vamsimanohar]

Signed-off-by: vamsi-amazon [email protected]

Description

Build is not getting triggered on updating PR with new commits.
Removed types under pull_request. This would default to opened, reopened, synchronize.
Ref for synchronize def: https://frontside.com/blog/2020-05-26-github-actions-pull_request/

Issues Resolved

[List any issues this PR will resolve]

Check List

• New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented.
  • New functionality has javadoc added
  • New functionality has user manual doc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #873 (6c4e747) into 2.x (3ca6450) will decrease coverage by 2.88%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x     #873      +/-   ##
============================================
- Coverage     97.85%   94.97%   -2.89%     
  Complexity     2989     2989              
============================================
  Files           281      291      +10     
  Lines          7357     8015     +658     
  Branches        467      586     +119     
============================================
+ Hits           7199     7612     +413     
- Misses          157      349     +192     
- Partials          1       54      +53     

Flag	Coverage Δ
query-workbench	62.76% <ø> (?)
sql-engine	97.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
workbench/public/components/PPLPage/PPLPage.tsx	56.52% <0.00%> (ø)
workbench/public/components/SQLPage/SQLPage.tsx	100.00% <0.00%> (ø)
...ch/public/components/QueryResults/QueryResults.tsx	61.60% <0.00%> (ø)
...ublic/components/QueryResults/QueryResultsBody.tsx	68.32% <0.00%> (ø)
workbench/public/components/app.tsx	0.00% <0.00%> (ø)
workbench/public/components/Header/Header.tsx	100.00% <0.00%> (ø)
workbench/public/application.tsx	0.00% <0.00%> (ø)
...h/public/components/QueryLanguageSwitch/Switch.tsx	85.71% <0.00%> (ø)
workbench/public/utils/PanelWrapper.tsx	100.00% <0.00%> (ø)
workbench/public/components/Main/main.tsx	53.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[dai-chen]

Thanks for the fix!

[joshuali925]

didn't know about synchronize

by default it will be triggered on three different types of activities: opened, synchronize, and reopened.

since it's default should types: just be removed?

[vamsimanohar]

didn't know about synchronize

by default it will be triggered on three different types of activities: opened, synchronize, and reopened.

since it's default should types: just be removed?

You are right. From the official documentation. https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows

Note: More than one activity type triggers this event. For information about each activity type, see "[Webhook events and payloads](https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#pull_request)." By default, a workflow only runs when a pull_request event's activity type is opened, synchronize, or reopened. To trigger workflows by different activity types, use the types keyword. For more information, see "[Workflow syntax for GitHub Actions](https://docs.github.com/en/articles/workflow-syntax-for-github-actions#onevent_nametypes)."

Will remove types entirely.