Add low-level create table and table exists API #834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (94.85%) is below the target coverage (99.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## feature/maximus-m1 #834 +/- ##
========================================================
+ Coverage 94.82% 94.85% +0.02%
- Complexity 2915 2927 +12
========================================================
Files 291 291
Lines 7794 7830 +36
Branches 567 568 +1
========================================================
+ Hits 7391 7427 +36
Misses 349 349
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Chen Dai <[email protected]>
MaxKsyunz
reviewed
Sep 16, 2022
opensearch/src/main/java/org/opensearch/sql/opensearch/client/OpenSearchClient.java
Outdated
Show resolved
Hide resolved
opensearch/src/main/java/org/opensearch/sql/opensearch/client/OpenSearchRestClient.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Chen Dai <[email protected]>
dai-chen
changed the title
joshuali925
approved these changes
Sep 19, 2022
opensearch/src/main/java/org/opensearch/sql/opensearch/client/OpenSearchNodeClient.java
Show resolved
Hide resolved
MaxKsyunz
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add create table and is table exists API on low level
TableandOpenSearchClientinterface. This is the prerequisite for adding system table and create materialized view functionality later. Because of only low-level code changes, IT will be added later. Publishing this PR earlier to avoid very large PR at last.Issues Resolved
#833
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.