Skip to content

Conversation

@dai-chen
Copy link
Collaborator

Signed-off-by: Chen Dai [email protected]

Description

Change masterNodeTimeout to new API clusterManagerNodeTimeout.

Issues Resolved

#463

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dai-chen dai-chen self-assigned this Aug 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.85%. Comparing base (eeb90cf) to head (e984b07).
⚠️ Report is 1048 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #793   +/-   ##
=========================================
  Coverage     94.85%   94.85%           
  Complexity     2913     2913           
=========================================
  Files           288      288           
  Lines          7839     7839           
  Branches        571      571           
=========================================
  Hits           7436     7436           
  Misses          349      349           
  Partials         54       54           
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine 97.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dai-chen dai-chen marked this pull request as ready for review August 30, 2022 21:02
@dai-chen dai-chen requested a review from a team as a code owner August 30, 2022 21:02
Copy link
Collaborator

@anirudha anirudha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dai-chen dai-chen merged commit 4e40ed2 into opensearch-project:main Sep 1, 2022
@dai-chen dai-chen deleted the change-master-timeout-nomenclature branch September 1, 2022 22:44
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 1, 2022
* Change master timeout to new API

Signed-off-by: Chen Dai <[email protected]>

* Change param name to cluster_manager_timeout

Signed-off-by: Chen Dai <[email protected]>

Signed-off-by: Chen Dai <[email protected]>
(cherry picked from commit 4e40ed2)
dai-chen added a commit that referenced this pull request Sep 7, 2022
* Change master timeout to new API

Signed-off-by: Chen Dai <[email protected]>

* Change param name to cluster_manager_timeout

Signed-off-by: Chen Dai <[email protected]>

Signed-off-by: Chen Dai <[email protected]>
(cherry picked from commit 4e40ed2)

Co-authored-by: Chen Dai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants